Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:pagination): nzItemRender support prev_5 and next_5 #4754

Merged
merged 1 commit into from
Feb 6, 2020
Merged

feat(module:pagination): nzItemRender support prev_5 and next_5 #4754

merged 1 commit into from
Feb 6, 2020

Conversation

vthinkxie
Copy link
Member

@vthinkxie vthinkxie commented Feb 5, 2020

BREAKING CHANGES:
prev_5 and next_5 is needed when use nzItemRender
'pre' typo was corrected to 'prev'

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #4754 into master will decrease coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4754      +/-   ##
==========================================
- Coverage   93.27%   93.25%   -0.02%     
==========================================
  Files         502      506       +4     
  Lines       12679    12776      +97     
  Branches     2011     2015       +4     
==========================================
+ Hits        11826    11914      +88     
- Misses        443      451       +8     
- Partials      410      411       +1
Impacted Files Coverage Δ
components/pagination/pagination.module.ts 100% <ø> (ø)
components/pagination/pagination-item.component.ts 100% <100%> (ø)
components/table/nz-th.component.ts 98.14% <100%> (+0.01%) ⬆️
...mponents/pagination/pagination-simple.component.ts 83.33% <83.33%> (ø)
...ponents/pagination/pagination-options.component.ts 92.85% <92.85%> (ø)
...ponents/pagination/pagination-default.component.ts 96.72% <96.72%> (ø)
components/pagination/pagination.component.ts 98.03% <98.03%> (ø)
components/core/util/check.ts 83.72% <0%> (-2.33%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39487f1...41e08ee. Read the comment docs.

BREAKING CHANGES:
prev_5 and next_5 is needed when use nzItemRender
'pre' typo was corrected to 'prev'
@vthinkxie vthinkxie merged commit 41c4860 into NG-ZORRO:master Feb 6, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ORRO#4754)

BREAKING CHANGES:
prev_5 and next_5 is needed when use nzItemRender
'pre' typo was corrected to 'prev'
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ORRO#4754)

BREAKING CHANGES:
prev_5 and next_5 is needed when use nzItemRender
'pre' typo was corrected to 'prev'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants