Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:tag): refactor #4793

Merged
merged 1 commit into from
Mar 2, 2020
Merged

refactor(module:tag): refactor #4793

merged 1 commit into from
Mar 2, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 17, 2020

This preview will be available after the AzureCI is passed.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev
Copy link
Member

wzhudev commented Feb 17, 2020

🤣

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #4793 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4793      +/-   ##
==========================================
- Coverage   93.21%   93.20%   -0.01%     
==========================================
  Files         505      505              
  Lines       12742    12740       -2     
  Branches     1955     1954       -1     
==========================================
- Hits        11877    11874       -3     
  Misses        455      455              
- Partials      410      411       +1     
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 97.31% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760512a...405ded1. Read the comment docs.

@hsuanxyz hsuanxyz merged commit fe0d91a into NG-ZORRO:master Mar 2, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 2, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the v9/tag branch August 5, 2020 02:27
wenqi73 added a commit to wenqi73/ng-zorro-antd that referenced this pull request Oct 15, 2020
related components: autocomplete, cascader, datepicker, timepicker, mention, popconfirm, popover, tooltip, select, treeselect

close NG-ZORRO#4793
close NG-ZORRO#5061
close NG-ZORRO#4259
close NG-ZORRO#2508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants