Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:badge): allow nzTitle set to null #4965

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Apr 1, 2020

close #4776

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4776

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 1, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #4965 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4965      +/-   ##
==========================================
+ Coverage   91.50%   91.53%   +0.03%     
==========================================
  Files         535      536       +1     
  Lines       13706    13705       -1     
  Branches     2048     2048              
==========================================
+ Hits        12541    12545       +4     
+ Misses        698      693       -5     
  Partials      467      467              
Impacted Files Coverage Δ
components/badge/badge.component.ts 98.30% <100.00%> (-0.06%) ⬇️
components/badge/preset-colors.ts 100.00% <100.00%> (ø)
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.04%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f606c...0fc420d. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit a35fb5e into NG-ZORRO:master Apr 7, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
Ricbet added a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:tooltip,etc): support custom origin (NG-ZORRO#4849)

* chore: sync ant-design v4.1.1 (NG-ZORRO#4987)

Co-authored-by: ng-zorro-bot <[email protected]>

* feat(module:code-editor): upgrade monaco to 0.20.0 and update interfaces (NG-ZORRO#4984)

* fix(module:badge): allow `nzTitle` set to null (NG-ZORRO#4965)

close NG-ZORRO#4776

* chore: add optional chaining and nullish coalescing (NG-ZORRO#4946)

* chore: add optional chaining and nullish coalescing

* test: fix tests

* test: fix tests

* feat(module:space): add new component (NG-ZORRO#4928)

close NG-ZORRO#4913

* feat: support compact theme (NG-ZORRO#4972)

Co-authored-by: Wendell <[email protected]>
Co-authored-by: ng-zorro-bot <[email protected]>
Co-authored-by: ng-zorro-bot <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: Wenqi <[email protected]>
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to hide nz-badge title
3 participants