Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:transfer): refactor #4985

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Apr 5, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4634

What is the new behavior?

Add NzSelectedKeys property. Sync antd

Does this PR introduce a breaking change?

[] Yes
[x] No

Other information

@Ricbet Ricbet changed the title Refactor transfer refactor(module:transfer): refactor Apr 5, 2020
@Ricbet Ricbet assigned Ricbet and unassigned vthinkxie Apr 5, 2020
@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #4985 into master will decrease coverage by 0.06%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4985      +/-   ##
==========================================
- Coverage   91.49%   91.43%   -0.07%     
==========================================
  Files         548      548              
  Lines       13771    13782      +11     
  Branches     2044     2046       +2     
==========================================
+ Hits        12600    12601       +1     
- Misses        709      717       +8     
- Partials      462      464       +2     
Impacted Files Coverage Δ
components/transfer/transfer-list.component.ts 96.29% <ø> (ø)
components/transfer/transfer-search.component.ts 100.00% <ø> (ø)
components/transfer/transfer.module.ts 100.00% <ø> (ø)
components/transfer/transfer.component.ts 92.00% <27.27%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf34d0...866364c. Read the comment docs.

@Ricbet Ricbet force-pushed the refactor-transfer branch 4 times, most recently from d5292e9 to 756e0c4 Compare April 9, 2020 03:53
@hsuanxyz hsuanxyz merged commit 9760238 into NG-ZORRO:master Apr 13, 2020
@pr-triage pr-triage bot added the PR: merged label Apr 13, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants