Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support strictTemplates for public components #5006

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #5006 into master will increase coverage by 0.02%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5006      +/-   ##
==========================================
+ Coverage   91.42%   91.44%   +0.02%     
==========================================
  Files         550      550              
  Lines       13689    13686       -3     
  Branches     2105     2105              
==========================================
  Hits        12515    12515              
+ Misses        712      709       -3     
  Partials      462      462              
Impacted Files Coverage Δ
components/affix/affix.component.ts 92.43% <ø> (ø)
components/alert/alert.component.ts 94.23% <ø> (ø)
components/anchor/anchor.component.ts 96.26% <ø> (ø)
...nts/auto-complete/autocomplete-option.component.ts 97.82% <ø> (ø)
components/auto-complete/autocomplete.component.ts 94.17% <ø> (ø)
components/back-top/back-top.component.ts 93.18% <ø> (ø)
components/badge/badge.component.ts 98.30% <ø> (ø)
components/breadcrumb/breadcrumb.component.ts 88.63% <0.00%> (+3.85%) ⬆️
components/button/button.component.ts 100.00% <ø> (ø)
components/calendar/calendar.component.ts 100.00% <ø> (ø)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206c3cc...ce285e4. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the feat/strictTemplates branch 2 times, most recently from bcd7891 to 19b386a Compare April 10, 2020 11:51
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit e0ca5fb into NG-ZORRO:master Apr 15, 2020
@wzhudev
Copy link
Member

wzhudev commented Apr 15, 2020

@vthinkxie Strict Property Initialization 要加吗,做这个之前需要完成 WithConfig 的重构哦

@vthinkxie
Copy link
Member

@vthinkxie Strict Property Initialization 要加吗,做这个之前需要完成 WithConfig 的重构哦

这个在 9.1 再上吧,今天来不及了

hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz mentioned this pull request Sep 9, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants