Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): modal cannot close after the host view destroyed #5161

Merged
merged 1 commit into from
May 11, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5128

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #5161 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5161      +/-   ##
==========================================
- Coverage   91.34%   91.30%   -0.04%     
==========================================
  Files         548      548              
  Lines       13870    13876       +6     
  Branches     2093     2093              
==========================================
+ Hits        12669    12670       +1     
- Misses        708      713       +5     
  Partials      493      493              
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/modal/utils.ts 100.00% <ø> (ø)
components/modal/modal-container.ts 87.27% <100.00%> (+0.23%) ⬆️
components/modal/modal-ref.ts 98.90% <100.00%> (+0.02%) ⬆️
components/modal/modal.component.ts 96.87% <100.00%> (+0.03%) ⬆️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b68dd...d58e844. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 5cb618e into NG-ZORRO:master May 11, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants