Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:all): Add RTL support to all ng-zorro-antd #5261

Closed
wants to merge 21 commits into from

Conversation

hdm91
Copy link
Contributor

@hdm91 hdm91 commented May 12, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1762

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

feat(module:table): add rtl tests and some rtl fixes

feat(module:grid): add rtl support

feat(module:demo): add some rtl fixes to whole demo

fix(module:layout): fix rtl button issue

feat(module:cascader): added rtl support

feat(module:carousel): added rtl direction

feat(module:button): added rtl direction

feat(module:layout): added rtl direction

feat(module:descriptions): added rtl direction

feat(module:menu): added rtl direction

fix(module:cascader): fix arrow direction in RTL

feat(module:breadcrumb): add rtl direction

feat(module:badge): add rtl direction

feat(module:comment): add rtl direction

feat(module:drawer): add rtl direction

feat(module:steps): add rtl direction

feat(module:tag): add rtl direction

feat(module:treeselect): add rtl direction

feat(module:typography): add rtl direction

feat(module:progress): add rtl direction

feat(module:rate): add rtl direction

feat(module:result): add rtl direction

feat(module:statistic): add rtl direction

feat(module:statistic): add rtl direction

feat(module:tooltip): wip add rtl-direction

feat(module:table): some rtl fixes after rebase

feat(module:popover): some rtl fixes after rebase

feat(module:tooltip): add rtl-direction

feat(module:affix): add rtl direction

feat(module:dropdown): add rtl direction

feat(module:pagination): add rtl direction

feat(module:select): add rtl direction

fix(module:breadcrumb): float in rtl

feat(module:page-header): add rtl direction

feat(module:autocomplete): add rtl direction

feat(module:checkbox): add rtl direction

feat(module:radio): add rtl direction

feat(module:switch): add rtl direction

feat(module:popover): add rtl direction

feat(module:datepicker): add rtl direction
@zorro-bot
Copy link

zorro-bot bot commented May 12, 2020

This preview will be available after the AzureCI is passed.

@hdm91
Copy link
Contributor Author

hdm91 commented May 12, 2020

Hi @vthinkxie I've rebase and started completing RTL support.

@vthinkxie
Copy link
Member

Hi @hdm91 great job, we will review once you finish it

@hdm91 hdm91 requested a review from danranVm as a code owner May 22, 2020 11:47
@hdm91 hdm91 requested a review from Ricbet as a code owner May 24, 2020 08:45
@vthinkxie
Copy link
Member

Hi @hdm91
it would be better to rebase on the master branch before you commit the codes

@hdm91
Copy link
Contributor Author

hdm91 commented May 25, 2020

Hi @vthinkxie
Sure, next time i'm going to rebase before the commits.
thanks

@wzhudev wzhudev mentioned this pull request Dec 9, 2020
@hsuanxyz hsuanxyz closed this in 860dfed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants