-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:table): col width not changed by nzWidth(#5324) #5353
fix(module:table): col width not changed by nzWidth(#5324) #5353
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5353 +/- ##
==========================================
- Coverage 91.35% 91.32% -0.04%
==========================================
Files 551 551
Lines 13909 13955 +46
Branches 2099 2113 +14
==========================================
+ Hits 12707 12744 +37
- Misses 712 719 +7
- Partials 490 492 +2
Continue to review full report at Codecov.
|
} | ||
} | ||
// If manualWidth is fully filled with width and the length is equal to autoWidth, regard autoWidth as the result. | ||
if (realManualWidthLength > 0 && realManualWidthLength === autoWidth.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this won't fix this issue since realManualWidthLength will equal autoWidth.length when update manualWidthConfigPx manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your advice. I'll try to fix this.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5324
What is the new behavior?
Does this PR introduce a breaking change?
Other information