Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): col width not changed by nzWidth(#5324) #5353

Conversation

qiurenbo
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5324

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 30, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #5353 into master will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5353      +/-   ##
==========================================
- Coverage   91.35%   91.32%   -0.04%     
==========================================
  Files         551      551              
  Lines       13909    13955      +46     
  Branches     2099     2113      +14     
==========================================
+ Hits        12707    12744      +37     
- Misses        712      719       +7     
- Partials      490      492       +2     
Impacted Files Coverage Δ
components/table/src/table-style.service.ts 91.37% <50.00%> (-4.85%) ⬇️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
components/page-header/page-header.component.ts 81.25% <0.00%> (-6.25%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/icon/icons.ts 100.00% <0.00%> (ø)
components/affix/utils.ts 100.00% <0.00%> (ø)
components/anchor/util.ts 100.00% <0.00%> (ø)
components/modal/utils.ts 100.00% <0.00%> (ø)
... and 503 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec427b4...48ef663. Read the comment docs.

}
}
// If manualWidth is fully filled with width and the length is equal to autoWidth, regard autoWidth as the result.
if (realManualWidthLength > 0 && realManualWidthLength === autoWidth.length) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this won't fix this issue since realManualWidthLength will equal autoWidth.length when update manualWidthConfigPx manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your advice. I'll try to fix this.

@vthinkxie
Copy link
Member

Hi @qiurenbo
I have fixed this issue in #5437
thanks for your PR anyway

@vthinkxie vthinkxie closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants