Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(all): upgrade to angular 5.0 #552

Merged
merged 1 commit into from
Nov 16, 2017
Merged

refactor(all): upgrade to angular 5.0 #552

merged 1 commit into from
Nov 16, 2017

Conversation

vthinkxie
Copy link
Member

close #520 close #514 close #533

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0%) to 40.357% when pulling 4346f3d on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

Copy link
Member

@wilsoncook wilsoncook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've local debugged:

  1. the "strictMetadataEmit" option will cause error while building from angular 5 (more about dependencies injection)
  2. rollup config should be upgraded, some annotations should listen to ts guide

This pr should be hung on for further obeservation, i'm going to commit my local changes to this branch

@wilsoncook wilsoncook closed this Nov 11, 2017
@wilsoncook wilsoncook deleted the angular-5.0 branch November 11, 2017 10:51
@vthinkxie vthinkxie reopened this Nov 12, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0%) to 40.357% when pulling d52c6bb on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0007%) to 40.318% when pulling 2bc3d94 on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0007%) to 40.318% when pulling 2bc3d94 on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0007%) to 40.318% when pulling 0f1df4e on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0007%) to 40.318% when pulling b08e822 on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0007%) to 40.318% when pulling 186321e on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0007%) to 40.318% when pulling 186321e on vthinkxie:angular-5.0 into 35112e8 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 8dd8a43 into NG-ZORRO:master Nov 16, 2017
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants