Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix table filter false or 0 error #5535

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

vthinkxie
Copy link
Member

close #5505

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 9, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #5535 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5535   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files         454      454           
  Lines       13939    13939           
  Branches     2218     2218           
=======================================
  Hits        12714    12714           
  Misses        720      720           
  Partials      505      505           
Impacted Files Coverage Δ
components/table/src/addon/filter.component.ts 57.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f133af...b987ab4. Read the comment docs.

@vthinkxie vthinkxie merged commit 56f052c into NG-ZORRO:master Jul 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

表格筛选单选时给NzTableFilterList中的value传0或false会抛出null
1 participant