Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:typography): support success type #5915

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Oct 14, 2020

close #5906

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5906

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 14, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #5915 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5915      +/-   ##
==========================================
- Coverage   90.02%   90.01%   -0.02%     
==========================================
  Files         463      463              
  Lines       13946    13946              
  Branches     2201     2201              
==========================================
- Hits        12555    12553       -2     
- Misses        857      859       +2     
  Partials      534      534              
Impacted Files Coverage Δ
components/typography/typography.component.ts 97.72% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 80.91% <0.00%> (-1.42%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5fdee...8b36ed3. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 93c0d46 into NG-ZORRO:master Oct 23, 2020
@hsuanxyz hsuanxyz deleted the feat/typography-types branch October 23, 2020 07:45
@pr-triage pr-triage bot added the PR: merged label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typography] support success type
1 participant