Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): menu closing behavoir #6023

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(module:cascader): menu closing behavoir #6023

merged 1 commit into from
Nov 9, 2020

Conversation

rppig42
Copy link
Contributor

@rppig42 rppig42 commented Nov 6, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Cascader popover is not closed after clicking a none-leaf node when using nzChangeOnSelect and hover trigger, which is very misleading.

Issue Number: #6022

What is the new behavior?

Cascader popover is closed after clicking a none-leaf node when using nzChangeOnSelect and hover trigger

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

https://react-fvmcpb-2ij3hv.stackblitz.io
Both react and vue port of Ant Design works well

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #6023 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6023   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         465      465           
  Lines       14042    14042           
  Branches     2306     2307    +1     
=======================================
  Hits        12632    12632           
  Misses        863      863           
  Partials      547      547           
Impacted Files Coverage Δ
components/cascader/cascader.component.ts 94.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af418b...5de42e6. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hsuanxyz hsuanxyz merged commit 22aea7e into NG-ZORRO:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants