Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): restore its value after cancel search #6088

Merged

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

close #6036

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #6088 (6696490) into master (3204927) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6088   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         465      465           
  Lines       14057    14097   +40     
  Branches     2311     2237   -74     
=======================================
+ Hits        12636    12673   +37     
+ Misses        873      872    -1     
- Partials      548      552    +4     
Impacted Files Coverage Δ
components/cascader/cascader.component.ts 94.51% <100.00%> (-0.16%) ⬇️
components/tree-select/tree-select.component.ts 90.13% <0.00%> (-3.43%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/config/config.ts 100.00% <0.00%> (ø)
components/cascader/cascader-li.component.ts 100.00% <0.00%> (ø)
components/drawer/drawer.component.ts 97.88% <0.00%> (+0.03%) ⬆️
components/pagination/pagination.component.ts 98.63% <0.00%> (+0.12%) ⬆️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3204927...6696490. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a codestyle change requested.

@@ -429,6 +429,10 @@ export class NzCascaderComponent implements NzCascaderComponentAsSource, OnInit,
this.cascaderService.syncOptions();
}

if (!visible) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use else.

@wzhudev wzhudev merged commit 22ddc60 into NG-ZORRO:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader should restore its value after cancel search
2 participants