Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:all): remove property for static host className #664

Merged
merged 1 commit into from
Dec 6, 2017
Merged

refactor(module:all): remove property for static host className #664

merged 1 commit into from
Dec 6, 2017

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Dec 2, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: closes #649

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 41.351% when pulling 6860f54 on trotyl:static-host-class into 9073bc8 on NG-ZORRO:master.

@trotyl
Copy link
Contributor Author

trotyl commented Dec 2, 2017

Coverage rate decreased due to removal of already covered properties, didn't affect real coverage.

x - 1   x
----- < -
y - 1   y     (x > 1, y > 1)

Ready for review.

@trotyl trotyl changed the title [WIP] refactor(module:all): remove property for static host className refactor(module:all): remove property for static host className Dec 2, 2017
@vthinkxie
Copy link
Member

seems conflict with #459

@trotyl
Copy link
Contributor Author

trotyl commented Dec 5, 2017

Confirmed, will solve it

@trotyl
Copy link
Contributor Author

trotyl commented Dec 5, 2017

CI failure due to rebased to current master, will rebase again after #679.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 41.086% when pulling ad900d8 on trotyl:static-host-class into 8ba3ea8 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit cc1a3f4 into NG-ZORRO:master Dec 6, 2017
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: no property for static className
3 participants