Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:inputNumber): limit integer, decimal input and decimal in… #82

Closed
wants to merge 1 commit into from
Closed

feat(module:inputNumber): limit integer, decimal input and decimal in… #82

wants to merge 1 commit into from

Conversation

giscafer
Copy link
Contributor

…put control by nzStep

nzStep is a integer,limit only integer input

close #42

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

…put control by nzStep

nzStep is a integer,limit only integer input

close #42
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.163% when pulling e8f8f9e on giscafer:inputNumber-limit-input into 44865c2 on NG-ZORRO:master.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your pr very much.
I suggest this component should keep the same behavior as https://ant.design/components/input-number-cn/ that user can input any char but the value will be validated when blur event is triggered.

@vthinkxie
Copy link
Member

I'll close the PR for the time being.
Please comment if I'm missing something.

@vthinkxie vthinkxie closed this Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputNumber 可以只限制输入数字吗?
3 participants