Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(module:modal): refactor modal component #920

Merged
merged 1 commit into from
Feb 27, 2018
Merged

refactor(module:modal): refactor modal component #920

merged 1 commit into from
Feb 27, 2018

Conversation

wilsoncook
Copy link
Member

@wilsoncook wilsoncook commented Jan 17, 2018 •
edited by vthinkxie
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #317 #644

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wilsoncook wilsoncook force-pushed the refactor_modal branch 2 times, most recently from a9b5cdc to 3dd5356 Compare January 17, 2018 07:36
@wilsoncook wilsoncook changed the base branch from master to 0.7.0 January 17, 2018 08:08
@wilsoncook wilsoncook added this to the 0.7.0 milestone Jan 17, 2018
@wilsoncook wilsoncook changed the title feat(module:nzx-modal): add(refactor) the new modal component refactor(module:modal): refactor modal component Jan 18, 2018
@wilsoncook wilsoncook changed the title refactor(module:modal): refactor modal component [WIP]refactor(module:modal): refactor modal component Jan 22, 2018
@vthinkxie vthinkxie mentioned this pull request Jan 24, 2018
Closed
@coveralls
Copy link

coveralls commented Jan 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 98.14% when pulling 69d6edd on wilsoncook:refactor_modal into 95c854a on NG-ZORRO:0.7.0.

@wilsoncook wilsoncook force-pushed the refactor_modal branch 5 times, most recently from c16bbe0 to aec3dc8 Compare February 11, 2018 07:40
@wilsoncook wilsoncook force-pushed the refactor_modal branch 7 times, most recently from 8305166 to cbe0345 Compare February 27, 2018 02:26
@wilsoncook wilsoncook changed the title [WIP]refactor(module:modal): refactor modal component refactor(module:modal): refactor modal component Feb 27, 2018
@vthinkxie vthinkxie merged commit cb1792c into NG-ZORRO:0.7.0 Feb 27, 2018
@wilsoncook wilsoncook deleted the refactor_modal branch March 9, 2018 09:22
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@wilsoncook @vthinkxie
refactor(module:modal): refactor of modal with more flexible and ease…
c045f04 
…-of-use. (NG-ZORRO#920)

ref NG-ZORRO#317, ref NG-ZORRO#644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wilsoncook @coveralls @vthinkxie