Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRL-759 switch to using new app ID header #660

Merged
merged 20 commits into from
Jul 1, 2024
Merged

NRL-759 switch to using new app ID header #660

merged 20 commits into from
Jul 1, 2024

Conversation

eesa456
Copy link
Contributor

@eesa456 eesa456 commented Jun 27, 2024

No description provided.

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: d95e7a2a7d4ca7739a0200db49787682fbeb014b
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 149e75485917eac0955f70239bdee8e1d7b19e5c
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 421b2eb319a1d9698871a0b9f70e8a50e11bfd7f
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 7869dc43419ce9b6eaba49e109bec85aff784526
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 73c99fb54bca72e3eec73f5842feb7df6e249ed4
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 39af28dc641e17ad6f70c7cc3d2f042706f828eb
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: af6c4e87b127818d5a9ea3ec348cb0520abe5e07
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: ad35e5ec8965ad0c2b8bbc0186d1fedc02e330b6
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: bc7f1984f21eeeb8280efe75481740f0bb48276c
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 7511b43070abbd912206da16aa0698370ae1bc85
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

🚀 PR environment successfully deployed.
Commit Hash: 27d6f952961e89be17f415913dd46dd842dff23c
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

axelkrastek1-nhs
axelkrastek1-nhs reviewed Jul 1, 2024
View reviewed changes
layer/nrlf/core/tests/test_decorators.py Outdated Show resolved Hide resolved
scripts/get_s3_permissions.py Outdated Show resolved Hide resolved
tests/features/consumer/searchDocumentReference-failure.feature Outdated Show resolved Hide resolved
tests/features/consumer/searchPostDocumentReference-failure.feature Outdated Show resolved Hide resolved
tests/features/producer/readDocumentReference-failure.feature Show resolved Hide resolved
tests/features/steps/1_setup.py
raise ValueError("No permissions table provided")

pointer_types = [f"{system}|{value}" for system, value in context.table]
bucket = f"nhsd-nrlf--{context.env}--authorization-store"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bucket name will need changing to f"nhsd-nrlf--{context.env}-authorization-store" due to my changes. This is almost like a note to self. It might be a bit more complicated than that as we want to use dev instead of dev-0

scripts/get_s3_permissions.py Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 1, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

🚀 PR environment successfully deployed.
Commit Hash: 58c171f0837f082e5853fc0abd74235117ae5d1e
URL: https://nrl759-79ec67.api.record-locator.dev.national.nhs.uk/

@axelkrastek1-nhs axelkrastek1-nhs merged commit 58eca28 into develop Jul 1, 2024
9 checks passed
@axelkrastek1-nhs axelkrastek1-nhs deleted the feature/eema1-NRL-759-removeAppIDDependency branch July 1, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelkrastek1-nhs axelkrastek1-nhs axelkrastek1-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eesa456 @axelkrastek1-nhs