Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRL-936 add integration tests #698

Merged
merged 7 commits into from
Aug 27, 2024
Merged

NRL-936 add integration tests #698

merged 7 commits into from
Aug 27, 2024

Conversation

eesa456
Copy link
Contributor

@eesa456 eesa456 commented Jul 25, 2024

…ointer type

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: e9dedb391d9973489e9706fd352d188c5a9d7cfd
URL: https://nrl936-2b7b6a.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 43800f8ddcf37525ef6594061e639a4d1b5ad7d4
URL: https://nrl936-2b7b6a.api.record-locator.dev.national.nhs.uk/

@eesa456 eesa456 marked this pull request as ready for review July 25, 2024 09:51
@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 635a288cce8cd637e43f325cfbe76a977732f2eb
URL: https://nrl936-2b7b6a.api.record-locator.dev.national.nhs.uk/

axelkrastek1-nhs
axelkrastek1-nhs approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@axelkrastek1-nhs axelkrastek1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

axelkrastek1-nhs
axelkrastek1-nhs previously requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@axelkrastek1-nhs axelkrastek1-nhs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it is failing 🥲 You just need to add the id for the upsert I think.

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 2d940fdd35ba7c9efb0de5d1ee4b7cf03c9f5add
URL: https://nrl936-2b7b6a.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 54893e05276fa46b854ee6dd2655ba9b30b15bd5
URL: https://nrl936-2b7b6a.api.record-locator.dev.national.nhs.uk/

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 964ec3a91f0e2f8e37befe89f8c4cd236c9a7831
URL: https://nrl936-2b7b6a.api.record-locator.dev.national.nhs.uk/

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: d01e097c38129fca0a303373dbc3fc3ae3851ccd
URL: https://nrl936-2b7b6a.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs
mattdean3-nhs approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@mattdean3-nhs mattdean3-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪 👍

@mattdean3-nhs mattdean3-nhs removed the request for review from axelkrastek1-nhs August 27, 2024 14:09
@eesa456 eesa456 merged commit cc96bda into develop Aug 27, 2024
6 checks passed
@eesa456 eesa456 deleted the feature/eema1-NRL-936-custodianTypeMatchIntegrationTests branch August 27, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdean3-nhs mattdean3-nhs mattdean3-nhs approved these changes

@axelkrastek1-nhs axelkrastek1-nhs axelkrastek1-nhs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eesa456 @axelkrastek1-nhs @mattdean3-nhs