Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NRL-796] Require X-Request-Id and NHSD-Correlation-Id in all requests for lambda log correlation #699

Merged

Conversation

mattdean3-nhs
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 5, 2024

💥 Something went wrong while building the pull request environment.
Check Output Logs

Copy link

github-actions bot commented Aug 5, 2024

🚀 PR environment successfully deployed.
Commit Hash: 2cfdc0639cfc496ef7aef27bb74732ab115ca5e8
URL: https://nrl796-265916.api.record-locator.dev.national.nhs.uk/

Copy link
Contributor

@axelkrastek1-nhs axelkrastek1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check of headers to integrations test happy path

layer/nrlf/core/constants.py Show resolved Hide resolved
layer/nrlf/core/decorators.py Outdated Show resolved Hide resolved
layer/nrlf/core/decorators.py Outdated Show resolved Hide resolved
layer/nrlf/core/decorators.py Show resolved Hide resolved
layer/nrlf/tests/events.py Outdated Show resolved Hide resolved
layer/nrlf/tests/events.py Outdated Show resolved Hide resolved
layer/nrlf/core/tests/test_decorators.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 7, 2024

Copy link

github-actions bot commented Aug 7, 2024

🚀 PR environment successfully deployed.
Commit Hash: 8f4925d07df7fc3dfa86d7710e3140fca3234627
URL: https://nrl796-265916.api.record-locator.dev.national.nhs.uk/

@mattdean3-nhs mattdean3-nhs merged commit b9ad425 into develop Aug 9, 2024
6 checks passed
@mattdean3-nhs mattdean3-nhs deleted the feature/made14-NRL-796-req-ids-in-lambda-logs branch August 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants