Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ipv4Block and Ipv6Block. #298

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Add Ipv4Block and Ipv6Block. #298

merged 11 commits into from
Jul 31, 2024

Conversation

partim
Copy link
Member

@partim partim commented Jul 8, 2024

This PR adds new types Ipv4Block and Ipv6Block that wrap an IpBlock and enforce it to be of the correct address family. In addition it adds FromIterator impls to Ipv4Blocks and Ipv6Blocks.

@partim partim requested a review from a team July 8, 2024 09:05
Copy link
Member

@ximon18 ximon18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor observations.

src/repository/resources/ipres.rs Outdated Show resolved Hide resolved
src/repository/resources/ipres.rs Outdated Show resolved Hide resolved
src/repository/resources/ipres.rs Show resolved Hide resolved
src/repository/resources/ipres.rs Outdated Show resolved Hide resolved
src/repository/resources/ipres.rs Show resolved Hide resolved
src/repository/resources/ipres.rs Show resolved Hide resolved
src/repository/resources/ipres.rs Show resolved Hide resolved
src/repository/resources/ipres.rs Show resolved Hide resolved
@partim partim merged commit 32f7262 into main Jul 31, 2024
24 checks passed
@partim partim deleted the ipblock46 branch July 31, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants