Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogFactory.Setup - Make RegisterConfigSettings public #423

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented May 12, 2020

Fixing copy-paste code from NLog.Web. Was surprised that NLog.Extension.Logging was released before NLog 4.7.1 (Would have liked to be testing them all together first)

@codecov-io
Copy link

Codecov Report

Merging #423 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   82.32%   82.30%   -0.02%     
==========================================
  Files          14       14              
  Lines        1205     1204       -1     
  Branches      200      200              
==========================================
- Hits          992      991       -1     
  Misses        141      141              
  Partials       72       72              
Impacted Files Coverage Δ
...Logging/Config/SetupExtensionsBuilderExtensions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49fdab...444ab57. Read the comment docs.

@304NotModified
Copy link
Member

Was surprised that NLog.Extension.Logging was released before NLog 4.7.1

Well 4.7.1 is a bit stalled, so don't want to stall more.

@304NotModified 304NotModified added this to the 1.6.3 milestone May 12, 2020
@304NotModified 304NotModified merged commit 2e3650a into NLog:master May 12, 2020
@snakefoot
Copy link
Contributor Author

Guess you have to make a 1.6.4 milestone

@304NotModified 304NotModified modified the milestones: 1.6.3, 1.6.4 May 12, 2020
@304NotModified
Copy link
Member

Thanks, also 1.6.3 is not done yet I see (git tag, github release ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants