Register NLogProvider instead of NLogFactory #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So config made before UseNLog is still applied and Microsoft's addConsole is also working fixes NLog#199
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=====================================
Coverage 59% 59%
=====================================
Files 29 29
Lines 397 397
Branches 92 92
=====================================
Hits 233 233
Misses 128 128
Partials 36 36Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So config made before UseNLog is still applied and Microsoft's addConsole is also working
fixes #199
needed for backwardsomp.