Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspnet-traceidentifier: Support for ASP.NET (non-core) - requires IIS ETW #330

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Dec 2, 2018

Attempt to resolve #328

Extracted from HttpWorkerRequest.RequestTraceIdentifier. Requires IIS ETW feature enabled: https://docs.microsoft.com/en-us/iis/configuration/system.webServer/httpTracing/ (IIS7 - Win2008)

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #330 into master will decrease coverage by 2%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #330   +/-   ##
=====================================
- Coverage      64%    62%   -2%     
=====================================
  Files          32     33    +1     
  Lines         450    461   +11     
  Branches       98    101    +3     
=====================================
  Hits          287    287           
- Misses        127    138   +11     
  Partials       36     36
Impacted Files Coverage Δ
...utRenderers/AspNetTraceIdentifierLayoutRenderer.cs 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1097d...294ad5d. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #330 into master will increase coverage by <1%.
The diff coverage is 78%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #330    +/-   ##
======================================
+ Coverage      64%    64%   +<1%     
======================================
  Files          32     33     +1     
  Lines         450    461    +11     
  Branches       98    101     +3     
======================================
+ Hits          287    296     +9     
  Misses        127    127            
- Partials       36     38     +2
Impacted Files Coverage Δ
...utRenderers/AspNetTraceIdentifierLayoutRenderer.cs 82% <78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1097d...6509087. Read the comment docs.

@304NotModified 304NotModified changed the title Added aspnet-traceidentifier for AspNet for NLog.Web Added aspnet-traceidentifier Jan 5, 2019
@304NotModified 304NotModified changed the title Added aspnet-traceidentifier aspnet-traceidentifier: Support for ASP.NET (non-core) - requires IIS ETW Jan 5, 2019
@304NotModified
Copy link
Member

Thanks! Also for the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET 4 ASP.NET MVC Classic feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a layout renderer for correlation ID
2 participants