Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.x #305

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

v0.7.x #305

wants to merge 7 commits into from

Conversation

cschwan
Copy link
Contributor

@cschwan cschwan commented Aug 30, 2024

This is the patch branch for versions 0.7.x. Do not merge this branch into master!

@cschwan cschwan self-assigned this Aug 30, 2024
@felixhekhorn
Copy link
Contributor

let me repeat again what I was asking in #308


also note that in v0.7.4 the error is slightly different:

return self.raw.convolute_with_two(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument 'bin_indices': type mismatch:
 from=int64, to=uint64

do we want to keep fixing former version, or not?

@cschwan
Copy link
Contributor Author

cschwan commented Sep 3, 2024

I'm not sure I understand this: is 0.7.x broken in any way?

@felixhekhorn
Copy link
Contributor

I'm not sure I understand this: is 0.7.x broken in any way?

the bin_indices argument of convolute_with_* is (or seems to be) broken - but broken in a different way then master #308

@cschwan
Copy link
Contributor Author

cschwan commented Sep 5, 2024

I wouldn't say it's broken, it's just (from the POV of Python) unexpectedly strict. You must pass a numpy array and the types must be unsigned integers. I suppose that really is unnecessarily strict, and we should allow more flexibility. However, this would probably be a breaking change, so let's not change anything for 0.7.x.

@cschwan
Copy link
Contributor Author

cschwan commented Oct 4, 2024

This branch is outdated; before we make another 0.7.x release, we should first merge the following commits (probably):

  1. e6a2dea
  2. 49e1c08
  3. a3a0804
  4. 76a1e89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants