GitHub Issue NOAA-EMC/GSI#2. Final changes for GFSv16. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RussTreadon-NOAA
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
These changes were requested by NCO during their pre-implementation GFS v16 tests. Jobs JGDAS_AMOS_ANALYSIS_DIAG and JGDAS_ENKF_DIAG do not use variable LEVS. Thus, the LEVS sections of the jobs are removed. ush script radmon_err_rpt.sh used the wrong comment character, ! instead of #. This was corrected at NCO's request. None of these changes alter results generated by these jobs or script.
These changes should be considered for merger into the NOAA-EMC/GSI master.
MichaelLueken
force-pushed
the
feature/gfsda.v16.0.0_update
branch
from
dbfd312
to
5c3d4a8
Compare
|
These changes have been updated to the latest in NOAA-EMC/GSI master. Russ has given his approval to these changes. I will now give final approval and merge these changes to the NOAA-EMC/GSI master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final changes for GFS v16 that have not been merged to the NOAA-EMC/GSI authoritative master.