Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update path to global ctest model data #762

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Jun 24, 2024

Description
NCO requires model_data be replaced by model in COM paths. This PR updates the paths to input data for global GSI ctests to conform with this standard.

Resolves #761

Type of change

  • Maintenance

How Has This Been Tested?
Run global ctests on Dogwood, Hera, and Hercules

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing tests pass with my changes

@RussTreadon-NOAA
Copy link
Contributor Author

@KateFriedman-NOAA , if you have time your review and approval of the changes in this PR would be appreciated. This PR addresses the GSI portion of g-w issue #2886

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @RussTreadon-NOAA !

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @KateFriedman-NOAA for reviewing the changes and approving. GSI global ctests are currently running on Dogwood, Hercules and Hera. I'll fire off an Orion test after the Hercules test finishes. The PR will be scheduled for merger into develop upon successful completion of multi-platform global ctests.

@RussTreadon-NOAA
Copy link
Contributor Author

Oops, I forgot that we do not yet have an Orion Rocky 9 GSI build. GSI issue #754 was opened to document this task. Issue #754 remains open. Since the Hercules and Orion global GSI ctests pull data from the same directory, it is sufficient for this PR to run the test only on Hercules.

@RussTreadon-NOAA
Copy link
Contributor Author

Hercules global ctest

Test project /work2/noaa/da/rtreadon/git/gsi/model/build
    Start 1: global_4denvar
1/2 Test #1: global_4denvar ...................   Passed  1783.24 sec
    Start 7: global_enkf
2/2 Test #7: global_enkf ......................   Passed  1985.71 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 3769.97 sec

Confirm from run directories that background files link to model case directories.

@RussTreadon-NOAA
Copy link
Contributor Author

Hera global ctest

Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/model/build
    Start 1: global_4denvar
1/2 Test #1: global_4denvar ...................   Passed  1986.35 sec
    Start 7: global_enkf
2/2 Test #7: global_enkf ......................   Passed  755.20 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 2741.57 sec

Check run directories to confirm that background files are linked to model case directories.

@RussTreadon-NOAA
Copy link
Contributor Author

WCOSS2 (Dogwood) global ctest

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/model/build
    Start 1: global_4denvar
1/2 Test #1: global_4denvar ...................   Passed  4444.54 sec
    Start 7: global_enkf
2/2 Test #7: global_enkf ......................   Passed  1212.33 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 5656.98 sec

Check run directories to confirm that background files are linked to model case directories.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 6a87460 into NOAA-EMC:develop Jun 25, 2024
4 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/model branch June 26, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change model_data to model
2 participants