-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add :: symbol to read from nems.configure. Required for ESMF 8bs20+. #1
Conversation
@rsdunlapiv The hpc-stack on hera does not have a build for esmf/8_2_0_beta_snapshot_20+. What are your recommendations? |
@danrosen25 please see here for general instructions for testing UFS with ESMF beta snapshots, thanks to @aerorahul: I have a build of ESMF 8bs20 here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested these changes on Hera with
esmf/8_2_0_beta_snapshot_14
esmf/8_2_0_beta_snapshot_20
results were bit-for-bit and the HYCOM cap is correctly picking up the custom import and export fields.
@BinLiu-NOAA, @junwang-noaa |
@danrosen25 So far, Bin and I are the code managers. Would you please make a ufs-weather-model PR that uses this https://github.com/rsdunlapiv/HYCOM-src/tree/fix_imp_exp_read branch? This way ufs-weather-model will use the latest hycom cap. Thanks |
@rsdunlapiv |
@danrosen25 if the changes in this PR are backward compatible, can you commit the code? We will update the revision in ufs-weather-model in the PR of updating ESMF to public release 8.2.0. Thanks |
Merge pull request #1 from hafs-community/fix/cplmedtype
This small change is required to update UFS to ESMF8bs20+. This is due to an update in the NUOPC layer. The change is backward compatible, so this can be tested with the current version of ESMF under UFS, which is ESMF8bs14.