Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :: symbol to read from nems.configure. Required for ESMF 8bs20+. #1

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

rsdunlapiv
Copy link

@rsdunlapiv rsdunlapiv commented Oct 12, 2021

This small change is required to update UFS to ESMF8bs20+. This is due to an update in the NUOPC layer. The change is backward compatible, so this can be tested with the current version of ESMF under UFS, which is ESMF8bs14.

@rsdunlapiv
Copy link
Author

@danrosen25

@danrosen25
Copy link

@rsdunlapiv The hpc-stack on hera does not have a build for esmf/8_2_0_beta_snapshot_20+. What are your recommendations?

@rsdunlapiv
Copy link
Author

@danrosen25 please see here for general instructions for testing UFS with ESMF beta snapshots, thanks to @aerorahul:
https://github.com/esmf-org/esmf-test-scripts/tree/main/ufs

I have a build of ESMF 8bs20 here:
setenv ESMFMKFILE /scratch2/NCEPDEV/stmp1/Rocky.Dunlap/esmftest/ESMF-INSTALL/intel-18.0.5.274/impi-2018.0.4/esmf/8_2_0_beta_snapshot_20/lib/esmf.mk

Copy link

@danrosen25 danrosen25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes on Hera with
esmf/8_2_0_beta_snapshot_14
esmf/8_2_0_beta_snapshot_20
results were bit-for-bit and the HYCOM cap is correctly picking up the custom import and export fields.

@danrosen25
Copy link

@BinLiu-NOAA, @junwang-noaa
Who maintains the NOAA-EMC/HYCOM-src repository? The ESMF team has a cap fix needed for the ESMF 8.2.0 release. I've already tested it and it is both backwards compatible and fixes the issue.

@junwang-noaa
Copy link

@danrosen25 So far, Bin and I are the code managers. Would you please make a ufs-weather-model PR that uses this https://github.com/rsdunlapiv/HYCOM-src/tree/fix_imp_exp_read branch? This way ufs-weather-model will use the latest hycom cap. Thanks

@danrosen25
Copy link

@junwang-noaa
Copy link

junwang-noaa commented Nov 2, 2021

@danrosen25 if the changes in this PR are backward compatible, can you commit the code? We will update the revision in ufs-weather-model in the PR of updating ESMF to public release 8.2.0. Thanks

@danrosen25 danrosen25 merged commit 09bdf00 into NOAA-EMC:emc/develop Nov 3, 2021
BinLiu-NOAA added a commit that referenced this pull request Sep 13, 2022
Merge pull request #1 from hafs-community/fix/cplmedtype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants