Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

w3adc multiple switch enhancements #167

Closed
ukmo-ccbunney opened this issue Feb 11, 2020 · 2 comments
Closed

w3adc multiple switch enhancements #167

ukmo-ccbunney opened this issue Feb 11, 2020 · 2 comments
Assignees
@ukmo-ccbunney
Labels
enhancement New feature or request

Comments

@ukmo-ccbunney
Copy link
Collaborator

A recent PR (#160 ) added a multi-switch capability to w3adc.

It has been suggested that the number of switches per line be limited to 4 and the maximum input line length be increased to 172 characters.

The all_switches script also needs to be updated to handle multiple switches in the code.

Finally, the relavent section of the manual should be updated too.
@ukmo-ccbunney
Copy link
Collaborator Author

Branch https://github.com/ukmo-waves/WW3/tree/fb_ad3_multisw covers changes.

@ukmo-ccbunney ukmo-ccbunney self-assigned this Feb 11, 2020
@ukmo-ccbunney ukmo-ccbunney added the enhancement New feature or request label Feb 11, 2020
ajhenrique added a commit that referenced this issue Feb 11, 2020
@ajhenrique
BF OpenMp b4b (#160)
db2c794 
OpenMP bugfix package

* Including additional variables in PRIVATE OMP declaration in attempt to fix OMP b4b irreproducibility issue (Jim Abeles)
* Adding changes to several modules with OpenMP loops to declare properly PRIVATE variables and avoid suprious assignment of values that lead to b4b reproducibility issues. Expanded matrix_ncep to run hybrid MPI/OMP cases
* Modified w3adc.f to enable processing of multiple switches on a single line (to be continue as per #167 )
Co-authored-by: @JamesAbeles-NOAA and Chris Bunney <[email protected]> and @CarstenHansen
@ukmo-ccbunney
Copy link
Collaborator Author

Fixed in PR #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukmo-ccbunney ukmo-ccbunney

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ukmo-ccbunney