Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sea/swell correction options for ww3_uprstr method #30

Closed
ukmo-ansaulter opened this issue May 20, 2019 · 6 comments
Closed

add sea/swell correction options for ww3_uprstr method #30

ukmo-ansaulter opened this issue May 20, 2019 · 6 comments
Assignees
@ukmo-ansaulter
Labels
enhancement New feature or request

Comments

@ukmo-ansaulter
Copy link
Collaborator

Add in wave spectrum update method, following Lionello et al (1992), to ww3_uprstr.ftn
@ukmo-ansaulter
Copy link
Collaborator Author

For assignment to @ukmo-ansaulter

@ajhenrique ajhenrique added the enhancement New feature or request label May 20, 2019
@ukmo-ansaulter ukmo-ansaulter mentioned this issue Nov 4, 2019
Merged
@ukmo-ansaulter
Copy link
Collaborator Author

Code has now been updated and tested with Met Office regular and SMC grid trials suites, plus new regtests. Summary of changes is as follows:

  • Added UPD5 option; bulk change to wind-sea or full spectrum based on proportion of wind-sea
  • Added UPD6 option; as per UPD5 but wind-sea energy distribution is shifted in frequency space using Toba (1973)
  • WRST switch is used to read wind data from restart file for UPD5 and UPD6; this is the recommended option, although the facility to read from the anl.XXX file (SWH, WSPD, WDIR) is available
  • Regtests have been added for UPD5 and UPD6 options
  • The code in ww3_uprstr.ftn has been tidied to make the style for each option a little more consistent

Regtests with the updated code introduce changes in ww3_uprstr.out files; these are correcting a typo for the module name

@ukmo-ansaulter
Copy link
Collaborator Author

Review and pull request open on UKMO trusted repo: ukmo-waves#1

@ukmo-ccbunney assigned for review

@ukmo-ansaulter
Copy link
Collaborator Author

UKMO review complete and feature branch merged into UKMO repository develop branch
https://github.com/ukmo-waves/WW3/tree/develop

UKMO pull request to NOAA repository pending other UKMO develop updates

@ukmo-ccbunney ukmo-ccbunney mentioned this issue Nov 27, 2019
Merged
@aliabdolali
Copy link
Contributor

@ukmo-ccbunney can we close it?

@ukmo-ansaulter
Copy link
Collaborator Author

Yes we can @aliabdolali 👍

MatthewMasarik-NOAA pushed a commit that referenced this issue Oct 18, 2023
@ricampos
Merge pull request #30 from aliabdolali/feature/add_read_ascii_spec
5823938 
add swden_ww3_read_ascii.m  examples/Example_Directional_Spectral_Den…
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/WW3 that referenced this issue Apr 17, 2024
@edwardhartnett
Merge pull request NOAA-EMC#30 from edwardhartnett/ejh_0410
e7b5b1f 
Ejh 0410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukmo-ansaulter ukmo-ansaulter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aliabdolali @ajhenrique @ukmo-ansaulter