Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

w3triamd fails to build with gnu compiler #339

Closed
thesser1 opened this issue Mar 25, 2021 · 1 comment · Fixed by #340 or #347
Closed

w3triamd fails to build with gnu compiler #339

thesser1 opened this issue Mar 25, 2021 · 1 comment · Fixed by #340 or #347
Labels
bug Something isn't working

Comments

@thesser1
Copy link
Collaborator

Describe the bug
The w3triamd code fails to build with gnu compiler on develop branch.

To Reproduce
Compile ww3_grid with develop branch when using gnu compilers.

Expected behavior
Looks to be caused by using SIGN with real(4) and real(8) variables.
@thesser1 thesser1 added the bug Something isn't working label Mar 25, 2021
@aliabdolali
Copy link
Contributor

aliabdolali commented Mar 25, 2021 •
edited
Loading

@thesser1
Just from a conversation we had, a fix would be converting 360.0 to 360.0d0 to make it a real(8) instead of real(4) in:
https://github.com/NOAA-EMC/WW3/blob/develop/model/ftn/w3triamd.ftn#L2823-#L2828
So I keep it for the record here.

thesser1 added a commit to thesser1/WW3 that referenced this issue Mar 25, 2021
@thesser1
fixing issue NOAA-EMC#339 and adding usace regtest matrix
5500271
@thesser1 thesser1 mentioned this issue Mar 25, 2021
Merged
aliabdolali pushed a commit that referenced this issue Mar 26, 2021
@thesser1
fixing issue #339 and adding usace regtest matrix (#340)
c4926b5
@thesser1 thesser1 mentioned this issue Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing issue #339 and adding usace regtest matrix thesser1/WW3
Fb pdlib changes erdc/WW3
2 participants
@thesser1 @aliabdolali