Fb port2hera #107
Fb port2hera #107
Conversation
Includes NCEP development machine Hera to cmplr.env if blocks allowing compilation of WW3 executables under NEMS. A correction to run_test is made to allow empty values of the batchq parameter. * Adding hera for NEMS coupled application builds * more hera updates for NEMS * adding hera port to w3_setup * regtests scripts matrix_ncep and run_test: adding feature to run on several NCEP compute systems, adding a conditional statement on run_test to check if batchq parameter is non-empty and avoid error when it is.
…a requires flag to be -qopenmp instead of -openmp
…oth scripts work on Hera. Changes -openmp flag to -qopenmp
|
@aliabdolali @ukmo-ccbunney please review this PR. If approved, it will be merge after the ERDC pull request. The present PR adapts the package for running successfully on NCEP's new R&D machine Hera, including changes for NCEP's NEMS coupling. All NEMS tests and WW3 regtests completed successfully. However, a comparison with a previous baseline via matrix.comp is not possible. Let me know if you need more information to approve this request. |
|
@JessicaMeixner-NOAA please review the changes made for porting to the NCEP R&D machine both at the esmf and regtests capabilities. Some changes were made in addition to your commits 5cda252, 9424565, and f91cc37. |
There was a problem hiding this comment.
All looks sensble to me @ajhenrique.
The only thing that I would say (and it is being a bit nit-picky) is that there is inconsistent use of the equality operators = and == in some of the if statements for cmplr.env. I think both work, but I believe for string comparison in bash == is the correct choice.
|
@ajhenrique All the updates I made are in your commits now. I tried running NEMSfv3gfs and the fv3_wrtGauss_nemsio_c768 compset failed. I can send an email with code and log file information if needed or if you have a branch that works I can test that? I couldn't find a branch with WW3 porting to hera for NEMSfv3gfs so I just made my own local updates. |
Hi @JessicaMeixner-NOAA , I've added a branch ww3_hera to the NEMSfv3gfs vlab repo. Please try that pointing to branch FB_port2hera and let me know if that works. Note that the compset may take longer than the 30 min walltime limit for compsets, that limit may need to be increased. Thanks. |
|
@ajhenrique I assume you have successfully run the ww3 tests on that branch, yes? |
@JessicaMeixner-NOAA Pls check comment above: "WW3 regtests completed successfully". @ukmo-ccbunney I've made the use of the equality operator consistent in cmplr.env, thanks for pointing this out. I noticed there are more instances of inconsistent usage in other scripts that we will tackle in a separate cover. In view of recent discussion offline, and thanks to approvals by @aliabdolali @JessicaMeixner-NOAA and @ukmo-ccbunney I'll go ahead and merge this PR to develop and close. |
* Port 2 hera (NOAA-EMC#101) Includes NCEP development machine Hera to cmplr.env if blocks allowing compilation of WW3 executables under NEMS. A correction to run_test is made to allow empty values of the batchq parameter. * Adding hera for NEMS coupled application builds * regtests scripts matrix_ncep and run_test: adding feature to run on several NCEP compute systems, adding a conditional statement on run_test to check if batchq parameter is non-empty and avoid error when it is. * Adding hera option for openmp runs in regtests: intel compiler on hera requires flag to be -qopenmp instead of -openmp * Changing '=' to '==' in cpmlr.env for consistent usage when comparing strings.
Branch FB_port2hera provides changes to make WW3 package run on Hera, the NCEP/NOAA R&D machine (replacing Theia).
Includes