Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ug_imp_nmb_acc: Those changes to the number accuracy of the implicit … #1147

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

aronroland
Copy link
Collaborator

@aronroland aronroland commented Dec 19, 2023

Put the number accuracy of the solver to real precision. This was done once and somehow it got lost.

Pull Request Summary

When using the combination of the number precision as it was in develop the solver did not converge to number accuracy, which it does now.

Description

If u run e.g. tp2.6 and the solver does not converge below 10E-12, now it does.

Please also include the following information:

  • Add any suggestions for a reviewer
    bug
    -->

Issue(s) addressed

none

Commit Message

Correcting number accuracy within the implicit ug solver.

Check list

Testing

  • How were these changes tested?
    tp2.6
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    needs to be discussed, anyway. From my point of view we need to add more tests in e.g. 2.6, it will be discussed.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    No
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    Yes, if the implicit solver is of concern.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    2 be continued.

…solver have been forgotten to merge by me. The solver conevergence computation have not been good before due to the choosen accuracies.
@JessicaMeixner-NOAA
Copy link
Collaborator

@aronroland thank you for submitting this PR! As soon as the testing information from ERDC is added we'll start the tests and review.

@JessicaMeixner-NOAA
Copy link
Collaborator

Converting to draft. Please mark as ready to review when testing information is available.

@JessicaMeixner-NOAA JessicaMeixner-NOAA marked this pull request as draft January 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants