Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ice time variables to restart file #1224

Merged
merged 2 commits into from
May 9, 2024
Merged

Add ice time variables to restart file #1224

merged 2 commits into from
May 9, 2024

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

Description

This is a bug-fix cherry-picked from PR #1211 that was found when testing restart reproduciblity for wave-ice coupling. Two variables (TIC1, TIC5) are needed to be added to the restarts.

Note some instructions on how to convert restart files (not necessarily recommended) are being drafted here: https://github.com/NOAA-EMC/WW3/wiki/Converting-Binary-Restarts-from-Older-to-Newer-Versions

Issue(s) addressed

An issue was never created.

Commit Message

Add ice time variables to restart file

Check list

Testing

  • How were these changes tested? Matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) No, because we do not test restart-reproducibility for all configurations. This was found in coupling tests.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Matrix, Hera with Intel
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    There are lots of changes to answers because the restart files change. It's the expected diff's + lots of restart diffs.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    matrixCompFull.txt
    matrixCompSummary.txt
    matrixDiff.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA added the restart file changes With this PR, there is an addition/change to the restart file label May 3, 2024
@MatthewMasarik-NOAA
Copy link
Collaborator

Thank you @JessicaMeixner-NOAA, I'll start reviewing.

MatthewMasarik-NOAA
MatthewMasarik-NOAA approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Pass

Testing
Pass

**********************************************************************          
********************* non-identical cases ****************************          
**********************************************************************          
mww3_test_01/./work_PR2_UNO                     (1 files differ)                
mww3_test_01/./work_PR1_MPI                     (1 files differ)                
mww3_test_01/./work_PR3_UNO_MPI                     (1 files differ)            
mww3_test_01/./work_PR3_UQ                     (1 files differ)                 
mww3_test_01/./work_PR3_UNO                     (1 files differ)                
mww3_test_01/./work_PR1                     (1 files differ)                    
mww3_test_01/./work_PR2_UQ                     (1 files differ)                 
mww3_test_01/./work_PR2_UQ_MPI                     (1 files differ)             
mww3_test_01/./work_PR3_UQ_MPI                     (1 files differ)             
mww3_test_01/./work_PR2_UNO_MPI                     (1 files differ)            
mww3_test_02/./work_PR1_c                     (2 files differ)                  
mww3_test_02/./work_PR2_UNO_c                     (2 files differ)              
mww3_test_02/./work_PR3_UQ_MPI_a                     (2 files differ)           
mww3_test_02/./work_PR1_MPI_d                     (2 files differ)              
mww3_test_02/./work_PR3_UNO_MPI_b_c                     (2 files differ)        
mww3_test_02/./work_PR3_UNO_c_c                     (2 files differ)            
mww3_test_02/./work_PR3_UQ_MPI_c                     (2 files differ)           
mww3_test_02/./work_PR2_UNO_MPI_d                     (2 files differ)          
mww3_test_02/./work_PR2_UNO_d                     (2 files differ)              
mww3_test_02/./work_PR2_UQ_MPI_a                     (2 files differ)           
mww3_test_02/./work_PR3_UQ_MPI_a_c                     (2 files differ)         
mww3_test_02/./work_PR3_UNO_MPI_d_c                     (2 files differ)        
mww3_test_02/./work_PR1_d                     (2 files differ)                  
mww3_test_02/./work_PR2_UQ_c                     (2 files differ)               
mww3_test_02/./work_PR3_UQ_b                     (2 files differ)               
mww3_test_02/./work_PR3_UQ_a                     (2 files differ)               
mww3_test_02/./work_PR1_a                     (2 files differ)                  
mww3_test_02/./work_PR3_UNO_MPI_d                     (2 files differ)          
mww3_test_02/./work_PR3_UNO_a_c                     (2 files differ)            
mww3_test_02/./work_PR2_UQ_MPI_b                     (2 files differ)           
mww3_test_02/./work_PR3_UNO_d                     (2 files differ)              
mww3_test_02/./work_PR3_UNO_MPI_c_c                     (2 files differ)        
mww3_test_02/./work_PR3_UNO_MPI_a_c                     (2 files differ)        
mww3_test_02/./work_PR2_UQ_a                     (2 files differ)               
mww3_test_02/./work_PR3_UNO_MPI_b                     (2 files differ)          
mww3_test_02/./work_PR3_UNO_b_c                     (2 files differ)            
mww3_test_02/./work_PR1_b                     (2 files differ)
mww3_test_02/./work_PR2_UNO_b                     (2 files differ)              
mww3_test_02/./work_PR3_UQ_MPI_c_c                     (2 files differ)         
mww3_test_02/./work_PR2_UQ_d                     (2 files differ)               
mww3_test_02/./work_PR3_UQ_c                     (2 files differ)               
mww3_test_02/./work_PR3_UNO_MPI_a                     (2 files differ)          
mww3_test_02/./work_PR1_MPI_c                     (2 files differ)              
mww3_test_02/./work_PR3_UNO_b                     (2 files differ)              
mww3_test_02/./work_PR1_MPI_b                     (2 files differ)              
mww3_test_02/./work_PR3_UQ_a_c                     (2 files differ)             
mww3_test_02/./work_PR3_UQ_MPI_b_c                     (2 files differ)         
mww3_test_02/./work_PR3_UQ_d_c                     (2 files differ)             
mww3_test_02/./work_PR1_MPI_a                     (2 files differ)              
mww3_test_02/./work_PR3_UQ_MPI_d_c                     (2 files differ)         
mww3_test_02/./work_PR3_UQ_MPI_d                     (2 files differ)           
mww3_test_02/./work_PR3_UQ_d                     (2 files differ)               
mww3_test_02/./work_PR3_UNO_d_c                     (2 files differ)            
mww3_test_02/./work_PR3_UQ_c_c                     (2 files differ)             
mww3_test_02/./work_PR2_UNO_MPI_b                     (2 files differ)          
mww3_test_02/./work_PR3_UNO_MPI_c                     (2 files differ)          
mww3_test_02/./work_PR2_UQ_b                     (2 files differ)               
mww3_test_02/./work_PR3_UNO_c                     (2 files differ)              
mww3_test_02/./work_PR3_UNO_a                     (2 files differ)              
mww3_test_02/./work_PR2_UQ_MPI_d                     (2 files differ)           
mww3_test_02/./work_PR2_UQ_MPI_c                     (2 files differ)           
mww3_test_02/./work_PR2_UNO_a                     (2 files differ)              
mww3_test_02/./work_PR2_UNO_MPI_c                     (2 files differ)          
mww3_test_02/./work_PR2_UNO_MPI_a                     (2 files differ)          
mww3_test_02/./work_PR3_UQ_b_c                     (2 files differ)             
mww3_test_02/./work_PR3_UQ_MPI_b                     (2 files differ)           
mww3_test_03/./work_PR1_MPI_e                     (4 files differ)              
mww3_test_03/./work_PR1_c                     (4 files differ)                  
mww3_test_03/./work_PR2_UNO_c                     (4 files differ)              
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (4 files differ)         
mww3_test_03/./work_PR3_UNO_e_c                     (4 files differ)            
mww3_test_03/./work_PR3_UQ_MPI_a                     (6 files differ)           
mww3_test_03/./work_PR1_MPI_d                     (12 files differ)             
mww3_test_03/./work_PR3_UNO_MPI_b_c                     (8 files differ)        
mww3_test_03/./work_PR2_UQ_e                     (4 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (17 files differ)      
mww3_test_03/./work_PR1_MPI_b                     (8 files differ)              
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (20 files differ)       
mww3_test_03/./work_PR3_UQ_a_c                     (6 files differ)             
mww3_test_03/./work_PR2_UNO_e                     (4 files differ)              
mww3_test_03/./work_PR3_UNO_MPI_d2                     (18 files differ)        
mww3_test_03/./work_PR3_UQ_MPI_b_c                     (8 files differ)         
mww3_test_03/./work_PR3_UQ_d_c                     (12 files differ)            
mww3_test_03/./work_PR2_UQ_MPI_d2                     (20 files differ)         
mww3_test_03/./work_PR1_MPI_a                     (6 files differ)              
mww3_test_03/./work_PR3_UQ_MPI_d_c                     (12 files differ)        
mww3_test_03/./work_PR3_UQ_MPI_d                     (12 files differ)          
mww3_test_03/./work_PR1_e                     (4 files differ)                  
mww3_test_03/./work_PR3_UQ_d                     (12 files differ)              
mww3_test_03/./work_PR3_UNO_d_c                     (12 files differ)           
mww3_test_03/./work_PR3_UQ_c_c                     (4 files differ)             
mww3_test_03/./work_PR3_UQ_MPI_e                     (4 files differ)           
mww3_test_03/./work_PR2_UNO_MPI_b                     (8 files differ)          
mww3_test_03/./work_PR3_UNO_MPI_c                     (4 files differ)          
mww3_test_03/./work_PR2_UQ_b                     (8 files differ)               
mww3_test_03/./work_PR3_UNO_c                     (4 files differ)              
mww3_test_03/./work_PR3_UNO_a                     (6 files differ)              
mww3_test_03/./work_PR2_UQ_MPI_d                     (12 files differ)          
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (4 files differ)        
mww3_test_03/./work_PR2_UQ_MPI_c                     (4 files differ)           
mww3_test_03/./work_PR2_UNO_a                     (6 files differ)              
mww3_test_03/./work_PR2_UNO_MPI_c                     (4 files differ)          
mww3_test_03/./work_PR2_UNO_MPI_a                     (6 files differ)          
mww3_test_03/./work_PR3_UQ_b_c                     (8 files differ)             
mww3_test_03/./work_PR3_UQ_MPI_b                     (8 files differ)           
mww3_test_03/./work_PR3_UQ_MPI_d2                     (20 files differ)         
mww3_test_04/./work_PR1_MPI_e                     (3 files differ)              
mww3_test_04/./work_PR3_UQ_MPI_e_c                     (3 files differ)         
mww3_test_04/./work_PR3_UQ_g                     (3 files differ)               
mww3_test_04/./work_PR1_MPI_d                     (6 files differ)              
mww3_test_04/./work_PR2_UQ_f                     (3 files differ)               
mww3_test_04/./work_PR3_UNO_MPI_b_c                  (3 files differ)
mww3_test_04/./work_PR3_UQ_MPI_c                     (3 files differ)           
mww3_test_04/./work_PR2_UNO_MPI_d                     (6 files differ)          
mww3_test_04/./work_PR3_UNO_g                     (3 files differ)              
mww3_test_04/./work_PR3_UNO_MPI_d_c                     (6 files differ)        
mww3_test_04/./work_PR3_UNO_MPI_e                     (3 files differ)          
mww3_test_04/./work_PR2_UQ_MPI_e                     (3 files differ)           
mww3_test_04/./work_PR3_UQ_b                     (3 files differ)               
mww3_test_04/./work_PR3_UQ_a                     (3 files differ)               
mww3_test_04/./work_PR1_a                     (3 files differ)                  
mww3_test_04/./work_PR3_UNO_g_c                     (3 files differ)            
mww3_test_04/./work_PR3_UNO_MPI_d                     (6 files differ)          
mww3_test_04/./work_PR2_UNO_MPI_e                     (3 files differ)          
mww3_test_04/./work_PR3_UNO_a_c                     (3 files differ)            
mww3_test_04/./work_PR2_UQ_MPI_b                     (3 files differ)           
mww3_test_04/./work_PR3_UNO_MPI_c_c                     (3 files differ)        
mww3_test_04/./work_PR2_UQ_a                     (3 files differ)               
mww3_test_04/./work_PR2_UNO_f                     (3 files differ)              
mww3_test_04/./work_PR3_UNO_MPI_b                     (3 files differ)          
mww3_test_04/./work_PR3_UNO_b_c                     (3 files differ)            
mww3_test_04/./work_PR1_b                     (3 files differ)                  
mww3_test_04/./work_PR2_UNO_b                     (3 files differ)              
mww3_test_04/./work_PR1_g                     (3 files differ)                  
mww3_test_04/./work_PR3_UQ_MPI_c_c                     (3 files differ)         
mww3_test_04/./work_PR1_MPI_c                     (3 files differ)              
mww3_test_04/./work_PR3_UNO_b                     (3 files differ)              
mww3_test_04/./work_PR1_MPI_b                     (3 files differ)              
mww3_test_04/./work_PR3_UQ_a_c                     (3 files differ)             
mww3_test_04/./work_PR3_UQ_MPI_b_c                     (3 files differ)         
mww3_test_04/./work_PR3_UQ_f_c                     (3 files differ)             
mww3_test_04/./work_PR3_UQ_g_c                     (3 files differ)             
mww3_test_04/./work_PR3_UQ_MPI_d_c                     (6 files differ)         
mww3_test_04/./work_PR3_UQ_MPI_d                     (6 files differ)           
mww3_test_04/./work_PR3_UQ_MPI_NC_b_c                     (3 files differ)      
mww3_test_04/./work_PR3_UQ_MPI_e                     (3 files differ)           
mww3_test_04/./work_PR3_UNO_f                     (3 files differ)              
mww3_test_04/./work_PR3_UNO_f_c                     (3 files differ)
mww3_test_04/./work_PR2_UNO_MPI_b                     (3 files differ)          
mww3_test_04/./work_PR1_f                     (3 files differ)                  
mww3_test_04/./work_PR3_UNO_MPI_c                     (3 files differ)          
mww3_test_04/./work_PR2_UQ_b                     (3 files differ)               
mww3_test_04/./work_PR2_UQ_g                     (3 files differ)               
mww3_test_04/./work_PR3_UNO_a                     (3 files differ)              
mww3_test_04/./work_PR2_UQ_MPI_d                     (6 files differ)           
mww3_test_04/./work_PR3_UNO_MPI_e_c                     (3 files differ)        
mww3_test_04/./work_PR2_UQ_MPI_c                     (3 files differ)           
mww3_test_04/./work_PR2_UNO_a                     (3 files differ)              
mww3_test_04/./work_PR2_UNO_MPI_c                     (3 files differ)          
mww3_test_04/./work_PR3_UQ_f                     (3 files differ)               
mww3_test_04/./work_PR3_UQ_b_c                     (3 files differ)             
mww3_test_04/./work_PR2_UNO_g                     (3 files differ)              
mww3_test_04/./work_PR3_UQ_MPI_b                     (3 files differ)           
mww3_test_05/./work_ST2_PR2_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST6_PR2_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST3_PR2_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST2_PR2_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST4_PR3_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST3_PR3_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST1_PR2_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST4_PR3_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST3_PR3_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST4_PR3_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST1_PR2_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST6_PR2_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST3_PR1_MPI                     (3 files differ)            
mww3_test_05/./work_ST3_PR2_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST4_PR2_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST6_PR2_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST3_PR3_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST3_PR2_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST3_PR3_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST6_PR2_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST6_PR3_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST3_PR2_UNO_OMP                     (3 files                
differ)
mww3_test_05/./work_ST4_PR2_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST1_PR3_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST4_PR3_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST2_PR3_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST4_PR3_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST6_PR1_MPI                     (3 files differ)            
mww3_test_05/./work_ST6_PR3_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST3_PR1_MPI_OMPH                     (3 files differ)       
mww3_test_05/./work_ST1_PR3_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST2_PR1_MPI                     (3 files differ)            
mww3_test_05/./work_ST6_PR3_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST1_PR3_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST4_PR1_MPI                     (3 files differ)            
mww3_test_05/./work_ST4_PR1_MPI_OMPH                     (3 files differ)       
mww3_test_05/./work_ST3_PR2_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST1_PR3_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST2_PR2_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST1_PR2_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST2_PR3_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST6_PR3_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST4_PR1_OMP                     (3 files differ)            
mww3_test_05/./work_ST1_PR3_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST2_PR2_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST2_PR3_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST1_PR1_MPI_OMPH                     (3 files differ)       
mww3_test_05/./work_ST4_PR3_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST6_PR2_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST4_PR2_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST1_PR3_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST2_PR2_UNO_OMP                     (3 files differ)        
mww3_test_05/./work_ST2_PR2_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST6_PR3_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST1_PR2_UQ_MPI                     (3 files differ)         
mww3_test_05/./work_ST3_PR2_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST3_PR3_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST4_PR2_UNO_MPI_OMPH                     (3 files           
differ)
mww3_test_05/./work_ST4_PR2_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST2_PR1_MPI_OMPH                     (3 files differ)       
mww3_test_05/./work_ST2_PR3_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST2_PR3_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST6_PR2_UNO_MPI_OMPH                     (3 files differ)   
mww3_test_05/./work_ST3_PR1_OMP                     (3 files differ)            
mww3_test_05/./work_ST2_PR3_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST2_PR1_OMP                     (3 files differ)            
mww3_test_05/./work_ST6_PR1_MPI_OMPH                     (3 files differ)       
mww3_test_05/./work_ST6_PR1_OMP                     (3 files differ)            
mww3_test_05/./work_ST6_PR3_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST4_PR2_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_05/./work_ST3_PR3_UQ_OMP                     (3 files differ)         
mww3_test_05/./work_ST1_PR2_UNO_MPI                     (3 files differ)        
mww3_test_05/./work_ST1_PR1_MPI                     (3 files differ)            
mww3_test_05/./work_ST1_PR1_OMP                     (3 files differ)            
mww3_test_05/./work_ST1_PR2_UQ_MPI_OMPH                     (3 files differ)    
mww3_test_06/./work_PR3_UNO_d                     (2 files differ)              
mww3_test_06/./work_PR3_UQ_d                     (2 files differ)               
mww3_test_07/./work_PR3_UQ                     (2 files differ)                 
mww3_test_08/./work_ST4_PR3_UQ_MPI                     (2 files differ)         
mww3_test_08/./work_lowres                     (1 files differ)                 
mww3_test_09/./work_MPI                     (3 files differ)                    
mww3_test_09/./work_MPI_ASCII                     (3 files differ)              
ww3_ta1/./work_UPD0F_O                     (2 files differ)                     
ww3_ta1/./work_UPD0F_U                     (2 files differ)                     
ww3_ta1/./work_UPD2_U_cap                     (2 files differ)                  
ww3_ta1/./work_UPD3_U                     (2 files differ)                      
ww3_ta1/./work_UPD5_U_cap                     (2 files differ)                  
ww3_ta1/./work_UPD6_O                     (2 files differ)                      
ww3_ta1/./work_UPD2_U                     (2 files differ)                      
ww3_ta1/./work_UPD5_O                     (2 files differ)                      
ww3_ta1/./work_UPD5_U                     (2 files differ)                      
ww3_ta1/./work_UPD3_U_cap                     (2 files differ)                  
ww3_ta1/./work_UPD3_O                     (2 files differ)                      
ww3_ta1/./work_UPD6_U                     (2 files differ)
ww3_ta1/./work_UPD2_O                     (2 files differ)                      
ww3_ta1/./work_UPD6_U_cap                     (2 files differ)                  
ww3_tbt1.1/./work_BT9                     (1 files differ)                      
ww3_tbt1.1/./work_BT9_MPI                     (1 files differ)                  
ww3_tbt1.1/./work_BT8_MPI                     (1 files differ)                  
ww3_tbt1.1/./work_BT8                     (1 files differ)                      
ww3_tbt2.1/./work_BT9                     (1 files differ)                      
ww3_tbt2.1/./work_BT9_MPI                     (1 files differ)                  
ww3_tbt2.1/./work_BT8_MPI                     (1 files differ)                  
ww3_tbt2.1/./work_BT8                     (1 files differ)                      
ww3_tic1.1/./work_1000m_IC3                     (1 files differ)                
ww3_tic1.1/./work_IC4_M5                     (1 files differ)                   
ww3_tic1.1/./work_IC5_M3                     (1 files differ)                   
ww3_tic1.1/./work_IC4_M6                     (1 files differ)                   
ww3_tic1.1/./work_IC3_CGICE_CHENG                     (1 files differ)          
ww3_tic1.1/./work_350m_IC3                     (1 files differ)                 
ww3_tic1.1/./work_2500m_IC1                     (1 files differ)                
ww3_tic1.1/./work_5km_IC1                     (1 files differ)                  
ww3_tic1.1/./work_1000m_IC2_nrl                     (1 files differ)            
ww3_tic1.1/./work_IC3_CGOW_CHENG_MPI                     (1 files differ)       
ww3_tic1.1/./work_IC4_M6L                     (1 files differ)                  
ww3_tic1.1/./work_IC5_M2                     (1 files differ)                   
ww3_tic1.1/./work_IC4_M3                     (1 files differ)                   
ww3_tic1.1/./work_1000m_nondisp_IC2_ifr                     (1 files differ)    
ww3_tic1.1/./work_350m_IC1                     (1 files differ)                 
ww3_tic1.1/./work_IC4_M6H                     (1 files differ)                  
ww3_tic1.1/./work_IC3_nondisp                     (1 files differ)              
ww3_tic1.1/./work_IC5_M1                     (1 files differ)                   
ww3_tic1.1/./work_1000m_nondisp_IC2_nrl                     (1 files differ)    
ww3_tic1.1/./work_1000m_IC1                     (1 files differ)                
ww3_tic1.1/./work_IC4_M7                     (1 files differ)                   
ww3_tic1.1/./work_IC4_M4                     (1 files differ)                   
ww3_tic1.1/./work_20km_IC1                     (1 files differ)                 
ww3_tic1.1/./work_IC4_M8                     (1 files differ)                   
ww3_tic1.1/./work_100m_IC1                     (1 files differ)                 
ww3_tic1.1/./work_2500m_IC3                     (1 files differ)
ww3_tic1.1/./work_IC3_CGICE_CHENG_MPI                     (1 files differ)      
ww3_tic1.1/./work_IC4_M2                     (1 files differ)                   
ww3_tic1.1/./work_IC4_M9                     (1 files differ)                   
ww3_tic1.1/./work_IC4_M1                     (1 files differ)                   
ww3_tic1.1/./work_IC3_CGOW_NOCHENG_MPI                     (1 files differ)     
ww3_tic1.1/./work_IC2_nondisp_SMPL                     (1 files differ)         
ww3_tic1.1/./work_10km_IC1                     (1 files differ)                 
ww3_tic1.2/./work_IC3_A0.5k_MPI                     (1 files differ)            
ww3_tic1.2/./work_IC3_B0.5k_MPI                     (1 files differ)            
ww3_tic1.2/./work_IC3_V1_G                     (1 files differ)                 
ww3_tic1.2/./work_IC3_B2.5k_MPI                     (1 files differ)            
ww3_tic1.2/./work_IC3_A2.5k                     (1 files differ)                
ww3_tic1.2/./work_IC3_A1.0k                     (1 files differ)                
ww3_tic1.2/./work_IC3_A2.5k_MPI                     (1 files differ)            
ww3_tic1.2/./work_IC3_CHENG                     (1 files differ)                
ww3_tic1.2/./work_IC3_B2.5k                     (1 files differ)                
ww3_tic1.2/./work_IC3_B0.5k                     (1 files differ)                
ww3_tic1.2/./work_IC3_V1_h                     (1 files differ)                 
ww3_tic1.2/./work_IC3_B1.0k_MPI                     (1 files differ)            
ww3_tic1.2/./work_IC3_B1.0k                     (1 files differ)                
ww3_tic1.2/./work_IC3_A0.5k                     (1 files differ)                
ww3_tic1.2/./work_IC3_A1.0k_MPI                     (1 files differ)            
ww3_tic1.3/./work_IC3_2.5k_PR3_UQ                     (1 files differ)          
ww3_tic1.3/./work_IC3_V1_G                     (1 files differ)                 
ww3_tic1.3/./work_IC3_2.5k_PR1                     (1 files differ)             
ww3_tic1.3/./work_IC3_CHENG                     (1 files differ)                
ww3_tic1.3/./work_IC3_0.5k_PR3_UNO                     (1 files differ)         
ww3_tic1.3/./work_IC3_2.5k_PR3_UNO                     (1 files differ)         
ww3_tic1.3/./work_IC3_0.5k_PR3_UQ                     (1 files differ)          
ww3_tic1.3/./work_IC3_2.5k_PR2_UNO                     (1 files differ)         
ww3_tic1.3/./work_IC3_V1_h                     (1 files differ)                 
ww3_tic1.3/./work_IC3_0.5k_PR2_UQ                     (1 files differ)          
ww3_tic1.3/./work_IC3_0.5k_PR2_UNO                     (1 files differ)         
ww3_tic1.3/./work_IC3_0.5k_PR1                     (1 files differ)             
ww3_tic1.3/./work_IC3_2.5k_PR2_UQ                     (1 files differ)
ww3_tic1.4/./work_IC1IS2_1000                     (1 files differ)              
ww3_tic1.4/./work_IC2IS2_IC2d                     (1 files differ)              
ww3_tic1.4/./work_IC2IS2_IC2b                     (1 files differ)              
ww3_tic1.4/./work_IC0IS2_1000                     (1 files differ)              
ww3_tic2.1/./work_IC1                     (1 files differ)                      
ww3_tic2.2/./work_IC2IS2                     (1 files differ)                   
ww3_tic2.3/./work_IC2IS2creep                     (1 files differ)              
ww3_tic2.3/./work_IC2IS2scat                     (1 files differ)               
ww3_tic2.3/./work_IC2IS2dissip                     (1 files differ)             
ww3_tig1.1/./work_IG1                     (1 files differ)                      
ww3_tp1.1/./work_PR2_UNO                     (1 files differ)                   
ww3_tp1.1/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.1/./work_PR3_UNO                     (1 files differ)                   
ww3_tp1.1/./work_PR1                     (1 files differ)                       
ww3_tp1.1/./work_PR2_UQ                     (1 files differ)                    
ww3_tp1.2/./work_PR2_UNO                     (1 files differ)                   
ww3_tp1.2/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.2/./work_PR3_UNO                     (1 files differ)                   
ww3_tp1.2/./work_PR1                     (1 files differ)                       
ww3_tp1.2/./work_PR2_UQ                     (1 files differ)                    
ww3_tp1.3/./work_PR2_UNO                     (1 files differ)                   
ww3_tp1.3/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.3/./work_PR3_UNO                     (1 files differ)                   
ww3_tp1.3/./work_PR1                     (1 files differ)                       
ww3_tp1.3/./work_PR2_UQ                     (1 files differ)                    
ww3_tp1.4/./work_PR2_UNO                     (1 files differ)                   
ww3_tp1.4/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.4/./work_PR3_UNO                     (1 files differ)                   
ww3_tp1.4/./work_PR1                     (1 files differ)                       
ww3_tp1.4/./work_PR2_UQ                     (1 files differ)                    
ww3_tp1.5/./work_PR2_UNO                     (1 files differ)                   
ww3_tp1.5/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.5/./work_PR3_UNO                     (1 files differ)                   
ww3_tp1.5/./work_PR1                     (1 files differ)                       
ww3_tp1.5/./work_PR2_UQ                     (1 files differ)                    
ww3_tp1.6/./work_PR2_UNO                     (1 files differ)                   
ww3_tp1.6/./work_PR3_UQ                     (1 files differ)
ww3_tp1.6/./work_PR3_UNO                     (1 files differ)                   
ww3_tp1.6/./work_PR1                     (1 files differ)                       
ww3_tp1.6/./work_PR2_UQ                     (1 files differ)                    
ww3_tp1.7/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.8/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.8/./work_BJ_PR3_UQ                     (1 files differ)                 
ww3_tp1.9/./work_PR3_UQ                     (1 files differ)                    
ww3_tp1.9/./work_PR3_UQ_MPI                     (1 files differ)                
ww3_tp2.1/./work_PR2_UNO                     (1 files differ)                   
ww3_tp2.1/./work_PR1_MPI                     (1 files differ)                   
ww3_tp2.1/./work_PR3_UNO_MPI                     (1 files differ)               
ww3_tp2.1/./work_PR3_UQ                     (1 files differ)                    
ww3_tp2.1/./work_PR3_UNO                     (1 files differ)                   
ww3_tp2.1/./work_PR1                     (1 files differ)                       
ww3_tp2.1/./work_PR2_UQ                     (1 files differ)                    
ww3_tp2.1/./work_PR2_UQ_MPI                     (1 files differ)                
ww3_tp2.1/./work_PR3_UQ_MPI                     (1 files differ)                
ww3_tp2.1/./work_PR2_UNO_MPI                     (1 files differ)               
ww3_tp2.10/./work_MPI                     (1 files differ)                      
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)                 
ww3_tp2.11/./work_MPI                     (1 files differ)                      
ww3_tp2.13/./work_PR1_TRPL                     (1 files differ)                 
ww3_tp2.13/./work_PR1_MPI                     (1 files differ)                  
ww3_tp2.13/./work_PR3_UQ                     (1 files differ)                   
ww3_tp2.13/./work_PR1                     (1 files differ)                      
ww3_tp2.13/./work_PR1_TRPL_MPI                     (1 files differ)             
ww3_tp2.13/./work_PR3_UQ_MPI                     (1 files differ)               
ww3_tp2.14/./work_OASACM6                     (1 files differ)                  
ww3_tp2.14/./work_OASACM3                     (2 files differ)                  
ww3_tp2.14/./work_OASACM5                     (1 files differ)                  
ww3_tp2.14/./work_OASACM4                     (2 files differ)                  
ww3_tp2.14/./work_OASACM                     (1 files differ)                   
ww3_tp2.14/./work_OASICM                     (1 files differ)                   
ww3_tp2.14/./work_OASACM2                     (1 files differ)                  
ww3_tp2.14/./work_OASOCM                     (1 files differ)                   
ww3_tp2.15/./work_PR3_UQ_RHO                     (1 files differ)
ww3_tp2.15/./work_5km                     (1 files differ)                      
ww3_tp2.15/./work_PR3_UQ_RHO_MPI                     (1 files differ)           
ww3_tp2.15/./work_ST6FLX5                     (1 files differ)                  
ww3_tp2.15/./work_PR3_UQ                     (1 files differ)                   
ww3_tp2.15/./work_MPI_5km                     (1 files differ)                  
ww3_tp2.15/./work_PR3_UQ_MPI                     (1 files differ)               
ww3_tp2.15/./work_ST4FLX5                     (1 files differ)                  
ww3_tp2.16/./work_MPI                     (1 files differ)                      
ww3_tp2.16/./work_MPI_OMPH                     (3 files differ)                 
ww3_tp2.17/./work_ma                     (3 files differ)                       
ww3_tp2.17/./work_a                     (3 files differ)                        
ww3_tp2.17/./work_mc1                     (3 files differ)                      
ww3_tp2.17/./work_mb                     (3 files differ)                       
ww3_tp2.17/./work_mc                     (3 files differ)                       
ww3_tp2.17/./work_ma1                     (3 files differ)                      
ww3_tp2.17/./work_c                     (3 files differ)                        
ww3_tp2.17/./work_b                     (3 files differ)                        
ww3_tp2.2/./work_PR2_UNO                     (1 files differ)                   
ww3_tp2.2/./work_PR1_MPI                     (1 files differ)                   
ww3_tp2.2/./work_PR3_UNO_MPI                     (1 files differ)               
ww3_tp2.2/./work_PR3_UQ                     (1 files differ)                    
ww3_tp2.2/./work_PR3_UNO                     (1 files differ)                   
ww3_tp2.2/./work_PR1                     (1 files differ)                       
ww3_tp2.2/./work_PR2_UQ                     (1 files differ)                    
ww3_tp2.2/./work_PR2_UQ_MPI                     (1 files differ)                
ww3_tp2.2/./work_PR3_UQ_MPI                     (1 files differ)                
ww3_tp2.2/./work_PR2_UNO_MPI                     (1 files differ)               
ww3_tp2.21/./work_ma                     (1 files differ)                       
ww3_tp2.21/./work_b_metis                     (1 files differ)                  
ww3_tp2.21/./work_a                     (1 files differ)                        
ww3_tp2.21/./work_mb                     (1 files differ)                       
ww3_tp2.21/./work_b                     (1 files differ)                        
ww3_tp2.3/./work_PR2_UNO                     (1 files differ)                   
ww3_tp2.3/./work_PR1_MPI                     (1 files differ)                   
ww3_tp2.3/./work_PR3_UNO_MPI                     (1 files differ)               
ww3_tp2.3/./work_PR3_UQ                     (1 files differ)
ww3_tp2.3/./work_PR3_UNO                     (1 files differ)                   
ww3_tp2.3/./work_PR1                     (1 files differ)                       
ww3_tp2.3/./work_PR2_UQ                     (1 files differ)                    
ww3_tp2.3/./work_PR2_UQ_MPI                     (1 files differ)                
ww3_tp2.3/./work_PR3_UQ_MPI                     (1 files differ)                
ww3_tp2.3/./work_PR2_UNO_MPI                     (1 files differ)               
ww3_tp2.4/./work_PR3_UNO_curv_MPI                     (1 files differ)          
ww3_tp2.4/./work_PR1_curv                     (1 files differ)                  
ww3_tp2.4/./work_PR2_UNO                     (1 files differ)                   
ww3_tp2.4/./work_PR2_UQ_curv_MPI                     (1 files differ)           
ww3_tp2.4/./work_PR1_MPI                     (1 files differ)                   
ww3_tp2.4/./work_PR3_UNO_MPI                     (1 files differ)               
ww3_tp2.4/./work_PR3_UQ                     (1 files differ)                    
ww3_tp2.4/./work_PR3_UNO                     (1 files differ)                   
ww3_tp2.4/./work_PR2_UNO_curv_MPI                     (1 files differ)          
ww3_tp2.4/./work_PR3_UQ_curv_MPI                     (1 files differ)           
ww3_tp2.4/./work_PR1                     (1 files differ)                       
ww3_tp2.4/./work_PR2_UQ                     (1 files differ)                    
ww3_tp2.4/./work_PR2_UNO_curv                     (1 files differ)              
ww3_tp2.4/./work_PR2_UQ_MPI                     (1 files differ)                
ww3_tp2.4/./work_PR3_UNO_curv                     (1 files differ)              
ww3_tp2.4/./work_PR3_UQ_curv                     (1 files differ)               
ww3_tp2.4/./work_PR2_UQ_curv                     (1 files differ)               
ww3_tp2.4/./work_PR3_UQ_MPI                     (1 files differ)                
ww3_tp2.4/./work_PR1_curv_MPI                     (1 files differ)              
ww3_tp2.4/./work_PR2_UNO_MPI                     (1 files differ)               
ww3_tp2.5/./work_REF_PR3_UNO                     (1 files differ)               
ww3_tp2.5/./work_REF_PR3_UNO_MPI                     (1 files differ)           
ww3_tp2.5/./work_REF_PR2_UQ_MPI                     (1 files differ)            
ww3_tp2.5/./work_PR2_UNO                     (1 files differ)                   
ww3_tp2.5/./work_PR1_MPI                     (1 files differ)                   
ww3_tp2.5/./work_PR3_UNO_MPI                     (1 files differ)               
ww3_tp2.5/./work_PR3_UQ                     (1 files differ)                    
ww3_tp2.5/./work_PR3_UNO                     (1 files differ)                   
ww3_tp2.5/./work_REF_PR1                     (1 files differ)                   
ww3_tp2.5/./work_PR1                     (1 files differ)                       
ww3_tp2.5/./work_PR2_UQ                     (1 files differ)                    
ww3_tp2.5/./work_REF_PR3_UQ_MPI                     (1 files differ)            
ww3_tp2.5/./work_PR2_UQ_MPI                     (1 files differ)
ww3_ts1/./work_ST4_T700                     (1 files differ)                    
ww3_ts1/./work_ST2                     (1 files differ)                         
ww3_ts1/./work_ST4_T500                     (1 files differ)                    
ww3_ts1/./work_ST6                     (1 files differ)                         
ww3_ts1/./work_ST1_RWND                     (1 files differ)                    
ww3_ts1/./work_NL5                     (1 files differ)                         
ww3_ts2/./work_ST6_PR3_UQ                     (1 files differ)                  
ww3_ts2/./work_ST3_PR3_UNO                     (1 files differ)                 
ww3_ts2/./work_ST4_PR1                     (1 files differ)                     
ww3_ts2/./work_ST4_PR3_UNO                     (1 files differ)                 
ww3_ts2/./work_ST6_PR2_UNO                     (1 files differ)                 
ww3_ts2/./work_ST6_PR2_UQ                     (1 files differ)                  
ww3_ts2/./work_ST3_PR2_UNO                     (1 files differ)                 
ww3_ts2/./work_ST1_PR1                     (1 files differ)                     
ww3_ts2/./work_ST3_PR1                     (1 files differ)                     
ww3_ts2/./work_ST2_PR3_UQ                     (1 files differ)                  
ww3_ts2/./work_ST2_PR3_UNO                     (1 files differ)                 
ww3_ts2/./work_ST3_PR2_UQ                     (1 files differ)                  
ww3_ts2/./work_ST4_PR3_UQ                     (1 files differ)                  
ww3_ts2/./work_ST1_PR2_UNO                     (1 files differ)                 
ww3_ts2/./work_ST2_PR1                     (1 files differ)                     
ww3_ts2/./work_ST6_PR1                     (1 files differ)                     
ww3_ts2/./work_ST3_PR3_UQ                     (1 files differ)                  
ww3_ts2/./work_ST6_PR3_UNO                     (1 files differ)                 
ww3_ts2/./work_ST2_PR2_UNO                     (1 files differ)                 
ww3_ts2/./work_ST4_PR2_UQ                     (1 files differ)                  
ww3_ts2/./work_ST4_PR2_UNO                     (1 files differ)                 
ww3_ts2/./work_ST2_PR2_UQ                     (1 files differ)                  
ww3_ts2/./work_ST1_PR2_UQ                     (1 files differ)                  
ww3_ts2/./work_ST1_PR3_UNO                     (1 files differ)                 
ww3_ts2/./work_ST1_PR3_UQ                     (1 files differ)                  
ww3_ts4/./work_rg_shel_MPI                     (1 files differ)                 
ww3_ts4/./work_ug_MPI                     (1 files differ)                      
ww3_ts4/./work_rg_multi_MPI                     (2 files differ)                
ww3_ufs1.1/./work_unstr_b                     (1 files differ)                  
ww3_ufs1.1/./work_c_npl                     (9 files differ)                    
ww3_ufs1.1/./work_unstr_a                     (1 files differ)                  
ww3_ufs1.1/./work_unstr_c                     (1 files differ)
ww3_ufs1.1/./work_d                     (9 files differ)                        
ww3_ufs1.1/./work_c_nth                     (9 files differ)                    
ww3_ufs1.1/./work_c                     (9 files differ)                        
ww3_ufs1.2/./work_a                     (27 files differ)                       
ww3_ufs1.2/./work_l                     (2 files differ)                        
ww3_ufs1.2/./work_c                     (7 files differ)                        
ww3_ufs1.2/./work_b                     (27 files differ)                       
ww3_ufs1.3/./work_a                     (27 files differ)

There were a lot of differences, but all seen to be the known non-b4b's along with differences in restart files expected from the changes.

Approve.

@MatthewMasarik-NOAA MatthewMasarik-NOAA merged commit c13d0b1 into NOAA-EMC:develop May 9, 2024
20 checks passed
@MatthewMasarik-NOAA
Copy link
Collaborator

Thanks for this fix to the restart files, @JessicaMeixner-NOAA!

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@MatthewMasarik-NOAA this was not my fix. It is the fix from dev/ufs-weather-model merged into develop.

@MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA this was not my fix. It is the fix from dev/ufs-weather-model merged into develop.

Okay, thanks for correcting the record and bringing the fix to develop. @NickSzapiro-NOAA thank you for supplying this fix.

@NickSzapiro-NOAA NickSzapiro-NOAA mentioned this pull request Jun 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewMasarik-NOAA MatthewMasarik-NOAA MatthewMasarik-NOAA approved these changes

Assignees
No one assigned
Labels
restart file changes With this PR, there is an addition/change to the restart file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JessicaMeixner-NOAA @MatthewMasarik-NOAA @NickSzapiro-NOAA