Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Gnu regtest CI failure #1253

Merged

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Jun 18, 2024

Pull Request Summary

Provides a fix for the Gnu github workflow regtest_gnu.yml added in commit 629d27a.

Description

  • Provide a detailed description of what this PR does.
    • There are two fixes and an added commented out section to address the failure:
      • typo in key
      • indentation needed for previously commented out lines
      • Commented out post run lines to avoid failures there
    • I wanted to point out regtest_gnu contains a working regtest w/ MPI running on Github Actions, which is a big milestone itself. Thanks to @edwardhartnett who did all the heavy lifting.
    • At another time the post run comparisons should be fixed. This is a lower priority currently.
  • What bug does it fix, or what feature does it add?
    • Bug fix for new Gnu regtest CI.
  • Is a change of answers expected from this PR?
    • No. The changes are confined to the github CI.

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added:
    • bug.
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply: mod_def change, out_grd change, out_pnt change, restart file change, Regression test
    • No. Only CI is modified.

Issue(s) addressed

  • Please list any issues associated with this PR, including those the PR will fix/close. For example:

Commit Message

Fix GNU regtest CI failure

Check list

Testing

  • How were these changes tested?
    • In Github Actions CI.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • N/A. No model code changes.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • N/A.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    • N/A

@MatthewMasarik-NOAA
Copy link
Collaborator Author

I updated the header Description and PR status. @CarstenHansen, let us know if this fix works for you.

@CarstenHansen
Copy link
Contributor

Yes, @MatthewMasarik-NOAA, your fix works for me on Github Actions without complains.

@JessicaMeixner-NOAA
Copy link
Collaborator

Thank you @MatthewMasarik-NOAA for the quick fix for this, and thank you @CarstenHansen for confirming this works!

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit f22c38a into NOAA-EMC:develop Jun 24, 2024
22 checks passed
@MatthewMasarik-NOAA
Copy link
Collaborator Author

Yes, @MatthewMasarik-NOAA, your fix works for me on Github Actions without complains.

Perfect, thanks for confirming @CarstenHansen.

@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the fix/gnu-regtest-ci branch June 24, 2024 17:52
ukmo-ccbunney added a commit to ukmo-waves/WW3 that referenced this pull request Sep 4, 2024
* origin/develop:
  Enable doxygen documentation in the cmake build system (NOAA-EMC#1281)
  Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266)
  Add depth scaling value to SMC regression tests. (NOAA-EMC#1264)
  Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263)
  Fix code stability issue in ww3_outp (NOAA-EMC#1258)
  Fix GNU regtest CI failure (NOAA-EMC#1253)
ukmo-ccbunney added a commit to ukmo-waves/WW3 that referenced this pull request Sep 4, 2024
* origin/develop:
  Enable doxygen documentation in the cmake build system (NOAA-EMC#1281)
  Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266)
  Add depth scaling value to SMC regression tests. (NOAA-EMC#1264)
  Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263)
  Fix code stability issue in ww3_outp (NOAA-EMC#1258)
  Fix GNU regtest CI failure (NOAA-EMC#1253)
ukmo-ccbunney added a commit to ukmo-waves/WW3 that referenced this pull request Sep 4, 2024
* feature/gpu/w3srce_refactor:
  Enable doxygen documentation in the cmake build system (NOAA-EMC#1281)
  Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266)
  Add depth scaling value to SMC regression tests. (NOAA-EMC#1264)
  Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263)
  Fix code stability issue in ww3_outp (NOAA-EMC#1258)
  Fix GNU regtest CI failure (NOAA-EMC#1253)
  Add option to use NetCDF output instead of binary for point output (NOAA-EMC#1230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The recent commit 629d27a has added a Github actions file (regtest_gnu) that fails with a syntax error message
3 participants