Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fb segfalt grdid #136

Merged
merged 7 commits into from
Jan 10, 2020
Merged

Fb segfalt grdid #136

merged 7 commits into from
Jan 10, 2020

Conversation

aliabdolali
Copy link
Contributor

@thesser1 @ajhenrique
Here is Mathieu bug fix for the segmentation fault.
The regression test is done successfully, the comparsion with NOAA develop is attached.

Insertion of the PDLIB stuff
Correct unset variable + segmentation fault.

comparison.zip
AA

@ajhenrique
Copy link
Collaborator

@aliabdolali as per recent discussion, there are several differences in out_pnt binary files that can't be clearly traced back to the changes in this PR, although it is likely that changing GRDID will change the binary point output. Please confirm if this is the case.

@aliabdolali
Copy link
Contributor Author

@aliabdolali as per recent discussion, there are several differences in out_pnt binary files that can't be clearly traced back to the changes in this PR, although it is likely that changing GRDID will change the binary point output. Please confirm if this is the case.
@ajhenrique I am doing one test before contacting Matheiu and Aron.
I'll confirm or ask him to take a look.
AA

Copy link
Collaborator

@ajhenrique ajhenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliabdolali as per discussion today, looks like all is in good shape.

@aliabdolali aliabdolali merged commit dd6d357 into NOAA-EMC:develop Jan 10, 2020
@aliabdolali aliabdolali deleted the fb_segfalt_grdid branch January 24, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants