allow mask variables to be retrieved from nems.configure #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Retrieves
mask_value_water
andmask_value_land
if present in nems.configure andmed_present
is true.Description
Currently, when used in UWM, wmesmf sets the import and export mask values for the grid from the default values.
These values are opposite the normal interpretation and CMEPS is then forced to set the dstMaskValue and srcMaskValues used for RH creation opposite to their normal sense. In med_map_mod, the currently used values in CMEPS for HAFS are (
n1
is the source side andn2
is the destination side)Both the
dstMaskValue
when the destination is compwav and thesrcMaskValue
when compwav is the source are reversed. That is, the dstMaskValue should indicate where the wave grid is masked when it is the destination. It should be 0 (ie, don't interpolate to the land points). The srcMaskValue should indicate what points to ignore when wave is the source. It should be 0 (ie, don't interpolate from land points on the wave grid).When HAFS is switched to the new cap, the mask values will be set with the correct interpretation for CMEPS. A PR for CMEPS # 266 is the first step in implementing the new wave cap in UWM. In order for the existing cap to continue to work for HAFS, it is required to allow non-default mask values to be set from nems.configure:
These will be consistent with the
dstMaskValue
andsrcMaskValue
used by CMEPS.These configuration variables will not be added to the HAFS nems.configure in UWM until CMEPS is also updated.
Issue(s) addressed
This PR allows the current wmesmf cap to continue to function for UFS HAFS apps during the transition to a CMEPS cap for both S2SW and HAFS.
Commit Message
Retrieve mask_value_water and mask_value_land if present in nems.configure and med_present is true.
Check list
Testing
Baselines were run on both Cheyenne.intel and Cheyenne.gnu using a feature branch of CMEPS incorporating changes required for S2SW coupling. All baselines were B4B. Tested hash #f297618 of FB updcmeps_wavcpl