NRL Neptune model 32-bit physics support #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2022
|
As of this posting, this PR is up-to-date with all submodules and has passed intel compiler tests (on jet) and gnu compiler tests (on hera). |
|
I have changed the |
17 tasks
DusanJovic-NOAA
approved these changes
May 26, 2022
ChunxiZhang-NOAA
approved these changes
May 26, 2022
|
@SamuelTrahanNOAA Please update .gitmodules and ccpp/physics hash (f13ed4e |
|
This branch now points to the NCAR main branch of ccpp/physics. |
BrianCurtis-NOAA
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ccpp-physics changes needed to support 32-bit physics on Neptune. This does not add 32-bit physics to FV3, which requires quite a lot more changes in several repositories.
Issue(s) addressed
Implements what this PR was supposed to:
NCAR/ccpp-physics#797
Which is about half of this batch of changes from NRL:
NCAR/ccpp-physics#772
Testing
Original testing was done on Neptune model by NRL. After that, it was tested in UFS, with these changes disabled. Finally, another set of branches (not in this PR) were developed that can successfully compile UFS for 32-bit physics, but not yet run it that way.
Dependencies
NCAR/ccpp-physics#918