Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RAP (Grell Freitas) decomp b4b issues #553

Merged

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Jun 10, 2022

This replaces #543, which is identical, but comes from another fork. All of this work comes from @climbfuji

Description

Update .gitmodules and submodule pointer for ccpp-physics for code review and testing of the changes described in NCAR/ccpp-physics#933.

Issue(s) addressed

See ufs-community/ufs-weather-model#1243.

Testing

See ufs-community/ufs-weather-model#1243.

Dependencies

waiting on NCAR/ccpp-physics#933
NOAA-GFDL/GFDL_atmos_cubed_sphere#194

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GF code changes in ccpp-physics look like mine, I don't know anything about the moninshoc or dycore updates.

@DusanJovic-NOAA
Copy link
Collaborator

Please list dycore PR as a dependency.

@SamuelTrahanNOAA
Copy link
Contributor Author

Please list dycore PR as a dependency.

I just added it. The merge is waiting on that dependency now; the ccpp-physics PR is already merged.

@SamuelTrahanNOAA
Copy link
Contributor Author

This PR is ready to be merged. The two PRs on which it depends have been merged, and the branch is updated to point to the head of the authoritative atmos_cubed_sphere and ccpp/physics branches.

@SamuelTrahanNOAA
Copy link
Contributor Author

I'd like @jkbk2004 to confirm he's ready for code managers to merge this.

@jkbk2004
Copy link
Collaborator

Sure! we can merge in this PR.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 9771e54 into NOAA-EMC:develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants