-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RAP (Grell Freitas) decomp b4b issues #553
Fix RAP (Grell Freitas) decomp b4b issues #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GF code changes in ccpp-physics look like mine, I don't know anything about the moninshoc or dycore updates.
Please list dycore PR as a dependency. |
I just added it. The merge is waiting on that dependency now; the ccpp-physics PR is already merged. |
This PR is ready to be merged. The two PRs on which it depends have been merged, and the branch is updated to point to the head of the authoritative atmos_cubed_sphere and ccpp/physics branches. |
I'd like @jkbk2004 to confirm he's ready for code managers to merge this. |
Sure! we can merge in this PR. |
This replaces #543, which is identical, but comes from another fork. All of this work comes from @climbfuji
Description
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing of the changes described in NCAR/ccpp-physics#933.
Issue(s) addressed
See ufs-community/ufs-weather-model#1243.
Testing
See ufs-community/ufs-weather-model#1243.
Dependencies
waiting on NCAR/ccpp-physics#933
NOAA-GFDL/GFDL_atmos_cubed_sphere#194