Fix boundary issues and numerical precision trouble in RUC LSM #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2022
SamuelTrahanNOAA
changed the title
DusanJovic-NOAA
approved these changes
Oct 14, 2022
ChunxiZhang-NOAA
approved these changes
Oct 14, 2022
|
@SamuelTrahanNOAA The submodule PRs have been merged, so this is ready to revert .gitmodules and update submodule pointers. |
|
@grantfirl @jkbk2004 Submodules are updated and fv3atm is ready for merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds changes needed for the RRFS regression tests to run in debug and 2threads mode on hera.gnu, hera.intel, and jet.intel. See the linked PRs for details
Issue(s) addressed
Boundary problems listed in NOAA-GFDL/GFDL_atmos_cubed_sphere#218 fixed by NOAA-GFDL/GFDL_atmos_cubed_sphere#219
Numerical precision issues listed in ufs-community/ccpp-physics#5 fixed by ufs-community/ccpp-physics#6
Testing
How were these changes tested?
RRFS debug mode cases on hera.intel, hera.gnu, and jet.intel, using gdb, ncview, and other tools, for many hours of debugging.
What compilers / HPCs was it tested with?
hera.intel, hera.gnu, jet.intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes; the RRFS will need 2threads and debug tests
Have the ufs-weather-model regression test been run? On what platform?
Yes, on hera.intel, hera.gnu, and jet.intel
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Yes; anything using boundary conditions or the ruclsm may change results. All regression tests at the ufs-weather-model level should match new baselines.
Please commit the regression test log files in your ufs-weather-model branch
Done.
Dependencies
ufs-community/ccpp-physics#6
NOAA-GFDL/GFDL_atmos_cubed_sphere#219