Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite. #799

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite. #799

merged 5 commits into from
Mar 27, 2024

Conversation

lisa-bengtsson
Copy link
Contributor

Description

This PR introduces namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite.

The default setting is .true. so all regression tests passes (on Hera). We recommend using .false. for C96 resolution.

Background:
Shan Sun, at GSL found the coupled SFS simulations (HR3 tag) at C96 have a drift in SST, not seen in C192 or C384. And not seen in P8 tag at C96 resolution.

I proposed that it is likely related to the cloud/convection/radiation interaction introduced in HR1 causing a feedback loop at when grid-mean suspended convective clouds are added to the cloud fraction at coarse resolution. Sensitivity tests showed that is the case. In discussion with Jongil Han, Ruiyu Sun and Fanglin Yang, EMC we propose to add a namelist flag that can be used for tuning at different applications (resolutions)

From Shan Sun, GSL:
image

Issue(s) addressed

Testing

Regression tests on Hera pass, not new baselines required

Dependencies

@lisa-bengtsson lisa-bengtsson mentioned this pull request Mar 12, 2024
Closed
14 tasks
@zach1221 zach1221 mentioned this pull request Mar 22, 2024
Merged
14 tasks
@grantfirl
Copy link
Collaborator

@lisa-bengtsson ufs-community/ccpp-physics#184 was merged, so this is ready to revert the changes in .gitmodules and update the ccpp-physics submodule pointer.

@zach1221
Copy link
Collaborator

@lisa-bengtsson ufs-community/ccpp-physics#184 was merged, so this is ready to revert the changes in .gitmodules and update the ccpp-physics submodule pointer.

@grantfirl it looks like Lisa is out of office this week until Friday. Could @DusanJovic-NOAA possibly make these updates?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 27, 2024 •
edited
Loading

@grantfirl @zach1221 let me see if I have permission.

@grantfirl
Copy link
Collaborator

@lisa-bengtsson ufs-community/ccpp-physics#184 was merged, so this is ready to revert the changes in .gitmodules and update the ccpp-physics submodule pointer.

@grantfirl it looks like Lisa is out of office this week until Friday. Could @DusanJovic-NOAA possibly make these updates?

Ya, whomever has write access to her fork could do this. I don't know who does though. Worst case scenario, someone (me or someone else) could create a new branch and PR that is identical for merging.

@lisa-bengtsson
Copy link
Contributor Author

@lisa-bengtsson ufs-community/ccpp-physics#184 was merged, so this is ready to revert the changes in .gitmodules and update the ccpp-physics submodule pointer.

@grantfirl it looks like Lisa is out of office this week until Friday. Could @DusanJovic-NOAA possibly make these updates?

Ya, whomever has write access to her fork could do this. I don't know who does though. Worst case scenario, someone (me or someone else) could create a new branch and PR that is identical for merging.

I can do it now, give me one second.

@jkbk2004
Copy link
Collaborator

@lisa-bengtsson I pushed update. Can you check?

@lisa-bengtsson
Copy link
Contributor Author

@jkbk2004 ok, thank you! That looks good to me.

@zach1221
Copy link
Collaborator

@lisa-bengtsson I pushed update. Can you check?

Thanks, @jkbk2004 ! Looks good to me as well. We're ready now to merge.

@jkbk2004 jkbk2004 merged commit 1ba8410 into NOAA-EMC:develop Mar 27, 2024
0 of 2 checks passed
zhanglikate added a commit to zhanglikate/fv3atm that referenced this pull request May 3, 2024
@zhanglikate
Squashed commit of the following:
9e250eb 
commit da95cc4
Author: WenMeng-NOAA <[email protected]>
Date:   Fri Apr 19 12:36:43 2024 -0400

    Update upp submodule (NOAA-EMC#811)

    * Update github workflow. Update gcc to 12 and mpi to openmpi

    * Add 'spack clean' to reduce the size of the cache files

    * Split GCC.yml workflow into two jobs, build_spack and build_fv3atm

    * Update github workflow. Add mpich

    * Update github actions to v4

    * Use action/cache/restore in build_fv3atm job

    * update upp revision to 5faac75

    * Update GCC.yml

    ---------

    Co-authored-by: Dusan Jovic <[email protected]>

commit 979bcab
Author: Dusan Jovic <[email protected]>
Date:   Wed Apr 17 13:42:06 2024 -0400

    Update dycore to remove compiler warnings (NOAA-EMC#813)

    * Update atmos_cubed_sphere and add compile definition BYPASS_BREED_SLP_INLINE to dycore

    * Pass correct mpi communicator type to post_alctvars routine in inline post

commit 37e7d48
Author: Samuel Trahan (NOAA contractor) <[email protected]>
Date:   Sun Apr 14 13:00:07 2024 -0400

    bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests (NOAA-EMC#806)

    * nesting fixes
    1. Initialize hailwat index in dynamical core.
    2. Use the correct tile number for nests in atmos_model.F90.

    * remove unneeded write statements

    * Fix kchunk3d in io/module_write_netcdf.F90

    ---------

    Co-authored-by: Dusan Jovic <[email protected]>

commit 383687e
Author: JONG KIM <[email protected]>
Date:   Thu Apr 4 16:34:52 2024 -0400

    cubed_sphere hash fix to f060e85 (NOAA-EMC#817)

    * Update cubed_sphere@f060e85 hash: a bug fix in the HAILCAST diagnostic code (units issue)

commit 1cac9d3
Author: Denise Worthen <[email protected]>
Date:   Wed Apr 3 16:48:31 2024 -0400

    Enable cpl_scalars (NOAA-EMC#794)

    * add cpl_scalars for atm

    * add field cpl_scalars to export state of fv3atm when coupled.
    cpl_scalars contain the dimensions of the fv3atm domain and are
    used by cmeps to write mediator history files as a single 2d
    grid for regional and 6 2d grids for CSG.

    * remove unused NUOPC use statement

commit 1b75fe2
Author: Dusan Jovic <[email protected]>
Date:   Mon Apr 1 17:12:08 2024 -0400

    Update module_write_netcdf to avoid hangs in RRFS runs (NOAA-EMC#803)

    * Split add_dim into two routines

    * Add NF90_NODIMSCALE_ATTACH constant

    * Test classic netcdf file formats

commit 1ba8410
Author: lisa-bengtsson <[email protected]>
Date:   Wed Mar 27 12:12:00 2024 -0600

    Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite. (NOAA-EMC#799)

    * Update ccpp/physics for namelist flag xr_cnvcld
@grantfirl grantfirl mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address convection/cloud/radiation interaction at coarse resolution
5 participants
@lisa-bengtsson @grantfirl @zach1221 @jkbk2004 @DusanJovic-NOAA