Bug fix for two-way nest updating #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensonr
reviewed
Apr 14, 2020
| @@ -2573,14 +2447,18 @@ subroutine twoway_nest_update(npx, npy, npz, zvir, ncnst, sphum, & | |||
| neststruct%isu, neststruct%ieu, neststruct%jsu, neststruct%jeu, & | |||
| npx, npy, npz, 0, 0, & | |||
| neststruct%refinement, neststruct%nestupdate, upoff, 0, & | |||
| neststruct%parent_proc, neststruct%child_proc, parent_grid, grid_number-1) | |||
| parent_grid%neststruct%parent_proc, neststruct%child_proc, parent_grid, grid_number-1) | |||
|
|
|||
| endif !conv_theta | |||
|
|
|||
| call mpp_sync!self | |||
There was a problem hiding this comment.
Do you want to perform an mpp_sync_self or is the full sync necessary here and down below the other update_coarse_grid?
|
Hi, Rusty. What is the difference between mpp_sync_self() and mpp_sync()?
Thanks,
Lucas
…On Mon, Apr 13, 2020 at 11:05 PM bensonr ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In model/fv_nesting.F90
<#21 (comment)>
:
> @@ -2573,14 +2447,18 @@ subroutine twoway_nest_update(npx, npy, npz, zvir, ncnst, sphum, &
neststruct%isu, neststruct%ieu, neststruct%jsu, neststruct%jeu, &
npx, npy, npz, 0, 0, &
neststruct%refinement, neststruct%nestupdate, upoff, 0, &
- neststruct%parent_proc, neststruct%child_proc, parent_grid, grid_number-1)
+ parent_grid%neststruct%parent_proc, neststruct%child_proc, parent_grid, grid_number-1)
endif !conv_theta
call mpp_sync!self
Do you want to perform an mpp_sync_self or is the full sync necessary here
and down below the other update_coarse_grid?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVHCPCO6IHMWZ6ABBU3RMPHJBANCNFSM4MHLXGRA>
.
|
|
@lharris4 mpp_sync requires all MPI-ranks to check in and wait for all to arrive before proceeding. mpp_sync_self only ensures that a give MPI-rank's outstanding sends and receives are completed before proceeding. |
|
Hi, Rusty. I usually use mpp_sync(). I don't recall if I had problems using
mpp_sync_self().
Thanks,
Lucas
…On Tue, Apr 14, 2020 at 9:24 AM bensonr ***@***.***> wrote:
@lharris4 <https://github.com/lharris4> *mpp_sync* requires all MPI-ranks
to check in and wait for all to arrive before proceeding. *mpp_sync_self*
only ensures that a give MPI-rank's outstanding sends and receives are
completed before proceeding.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVBWFFFR25MYF4A7KUDRMRPXXANCNFSM4MHLXGRA>
.
|
|
@lharris4 No worries - we'll publish it as is and explore the alternatives later. |
XiaqiongZhou-NOAA
referenced
this pull request
in XiaqiongZhou-NOAA/GFDL_atmos_cubed_sphere
Apr 16, 2020
bensonr
added a commit
that referenced
this pull request
Apr 21, 2020
* Add LICENSE.md * Renamed driver directories and removed the null version of the nh extensions for the public release * Update license header for FV3 * Added a README.md file * Replace GPL header with LGPL header * fixed license header in every file and added it to those without it * Master test (#17) * commit of new version of dycore from Weather and Climate Dynamics Group at GFDL * updated versions of GFDL-specific files from dev/gfdl * updated README.md with current release information * cleaned up a few lines in fv_dynamics * new file RELEASE.md with release notes documenting differences between this and the last release * updated RELEASE.md message * hand merge of diagnostic updates * remove trailing spaces from sources * updates to merge some GFDL specific updates into this public release * Master test (#18) * commit of new version of dycore from Weather and Climate Dynamics Group at GFDL * updated versions of GFDL-specific files from dev/gfdl * updated README.md with current release information * cleaned up a few lines in fv_dynamics * new file RELEASE.md with release notes documenting differences between this and the last release * updated RELEASE.md message * hand merge of diagnostic updates * remove trailing spaces from sources * updates to merge some GFDL specific updates into this public release * updated README.md * updated GFDL_tools/fv_cmip_diag to be consistent with dev/gfdl branch * Bug fix for two-way nest updating (#21) * remove trailing whitespace and any tabs * update the RELEASE.md with the FV3 technical memorandum * semantic fix in RELEASE.md * adds default values for nest_*offsets in fv_control breaks up a too long line in fv_nesting.F90 * change default value of nestupdate to 7 Co-authored-by: Seth Underwood <[email protected]> Co-authored-by: lharris4 <[email protected]>
climbfuji
added a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jun 7, 2020
* Add butterfly effect option. * Move butterfly effect option from external_ic.F90 to fv_restart.F90 * model/fv_arrays.F90: provide clarification of butterfly effect in comment Co-authored-by: Dusan Jovic <[email protected]>
christinaholtNOAA
pushed a commit
to NOAA-GSL/GFDL_atmos_cubed_sphere
that referenced
this pull request
May 25, 2021
* Add butterfly effect option. * Move butterfly effect option from external_ic.F90 to fv_restart.F90 * model/fv_arrays.F90: provide clarification of butterfly effect in comment Co-authored-by: Dusan Jovic <[email protected]>
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
…L#21-use-gftl-shared Fixes NOAA-GFDL#21 - use gFTL-shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.