Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed for FMS2023.03: Quad Precision macro change #299

Open
wants to merge 1 commit into
base: dev/emc
Choose a base branch
from

Conversation

laurenchilutti
Copy link
Contributor

Description

In FMS 2023.03, macro definitions are cleaned up in fms_platforms.h. As part of the cleanup, the definition of the macro NO_QUAD_PRECISION is removed, and the dycore is the only component that still used this macro. This PR replaces the use of the outdated NO_QUAD_PRECISION with ENABLE_QUAD_PRECISION. This update is backwards compatible and has been tested with GFDL models using both FMS 2023.02 and FMS 2023.03 (via testing tag 2023.03-beta1).

Fixes # (issue)

How Has This Been Tested?

We have tested with SHiELD model and need assistance testing with UFS weather model.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@bensonr
Copy link
Contributor

bensonr commented Jan 17, 2024

@jkbk2004 - I believe you are now using FMS 2023.03, does this need to be merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants