Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored DOME_initialize_sponges() #12

Merged

Commits on Nov 24, 2021

  1. Refactored DOME_initialize_sponges()

      Bitwise identical refactoring of the code in DOME_initialize_sponges,
    including renaming variables for greater clarity, adding variables for several
    dimensional constants, and correcting comments.  This also includes more careful
    handling of the DOME OBCs in DOME_set_OBC_data() to hopefully avoid some obvious
    problems (noted in a comment about a "fight with T,S") that would arise if a
    DOME case were set up that used temperature and salinity. Future revisions
    should add more runtime parameters to specify the details of this case, but
    properly doing so would involve changing the order of arithmetic; this has not
    happened in this case.  All real variables in this module are now described in
    comments.  All answers and output are bitwise identical.
    Hallberg-NOAA committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    5a130e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Configuration menu
    Copy the full SHA
    14f807a View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. Configuration menu
    Copy the full SHA
    459ecc0 View commit details
    Browse the repository at this point in the history