Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a couple of typos in hor_visc #4

Merged
merged 2 commits into from
Nov 21, 2021

Conversation

herrwang0
Copy link

  1. Three typos are corrected.
  2. An if-statement for better bound of the Laplacian viscosity at h-cell
    is moved outside of the do-loops.

1. Three typos are corrected.
2. An if-statement for better bound of the Laplacian viscosity at h-cell
is moved outside of the do-loops.
@herrwang0
Copy link
Author

PS: I am actually not sure if I should be submitting to this repo or the mom-ocean one (dev/gfdl branch there??). Let me know if I should redo this (or wait until the transition is finalized). Thanks!

@marshallward
Copy link
Member

@herrwang0 Let's handle this at NOAA-GFDL for now. We'll talk about how to handle PRs to mom-ocean at the next meetup.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #4 (844c4c7) into dev/gfdl (e2e5787) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl       #4   +/-   ##
=========================================
  Coverage     29.15%   29.15%           
=========================================
  Files           239      239           
  Lines         71463    71463           
=========================================
  Hits          20833    20833           
  Misses        50630    50630           
Impacted Files Coverage Δ
src/parameterizations/lateral/MOM_hor_visc.F90 44.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e5787...844c4c7. Read the comment docs.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these corrections. Thank you for spotting and correcting them @herrwang0.

This has passed TC testing, and it passed the MOM6 regression testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14120.

In your case, @herrwang0, NOAA-gfdl:dev/gfdl is the appropriate primary development fork, although for other people another one (like NCAR:dev/ncar or NOAA-emc:dev/emc) might be more appropriate.

I will be updating MOM6-examples to reflect the altered MOM_parameter_doc files resulting from this PR.

@Hallberg-NOAA Hallberg-NOAA merged commit 7b96ac1 into NOAA-GFDL:dev/gfdl Nov 21, 2021
@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Feb 1, 2022
@herrwang0 herrwang0 deleted the hor_visc_typos branch June 21, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants