Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unpaired parentheses in a formatting string #525

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

Hallberg-NOAA
Copy link
Member

Fix unpaired parentheses in the format statement used in an error message about OBC segment data not being on the supergrid. All answers are bitwise identical, but there is one less compile-time warning.

  Fix unpaired parentheses in the format statement used in an error message
about OBC segment data not being on the supergrid.  All answers are bitwise
identical, but there is one less compile-time warning.
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (34b880f) 37.49% compared to head (49994e0) 37.49%.

Files Patch % Lines
src/core/MOM_open_boundary.F90 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           dev/gfdl     #525   +/-   ##
=========================================
  Coverage     37.49%   37.49%           
=========================================
  Files           271      271           
  Lines         79533    79533           
  Branches      14816    14816           
=========================================
  Hits          29818    29818           
  Misses        44175    44175           
  Partials       5540     5540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame this was not an error, IMO it should not have compiled!

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/21479 ✔️

@marshallward marshallward merged commit 11759d6 into NOAA-GFDL:dev/gfdl Nov 27, 2023
12 checks passed
@Hallberg-NOAA Hallberg-NOAA deleted the OBC_warning_format_fix branch May 10, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants