Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+*Add and revise step_MOM_dyn_split_RK2b #534

Merged
merged 5 commits into from
Dec 22, 2023

Commits on Dec 20, 2023

  1. +Add MOM_dynamics_split_RK2b enabled by SPLIT_RK2B

      Add the new module MOM_dynamics_split_RK2b and calls to the routines in this
    module to MOM.F90.  These calls are exercised when the run time parameter
    SPLIT_RK2B is true.  For now, all answers are bitwise identical when this new
    code is being exercised, but there is a new module with multiple public
    interfaces and a new entry in many MOM_parameter_doc files.
    Hallberg-NOAA committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c9f3349 View commit details
    Browse the repository at this point in the history
  2. *+Revise algorithm in step_MOM_dyn_split_RK2b

      Revised step_MOM_dyn_split_RK2b to use the time-filtered velocities as
    arguments and reconstruct the instantaneous velocities with the proper phase
    from the barotropic solver from the saved increments du_av_inst and dv_av_inst.
    As a part of this change, the continuity solver is used to find the thickness
    fluxes used in the predictor step Coriolis terms, and the horizontal viscous
    accelerations are calculated for both the predictor and corrector steps, thereby
    avoiding the need to vertically remap any 3-d fields apart from a single pair of
    velocity components.
    
      The run-time option STORE_CORIOLIS_ACCEL is no longer used when SPLIT_RK2B =
    True.  FPMIX was also disabled in this mode due to unresolved dimensional
    inconsistency errors in that code.
    
      Additionally, the time-filtered velocities are now used instead of the
    instantaneous velocities in the second call to radiation_open_bdry_conds(),
    which should improve the performance of several of the Orlanski-type open
    boundary conditions.
    
      The 2-d fields du_av_inst and dv_av_inst were added to the restart file, while
    the 3-d fields u2, v2, diffu and diffv and either CAu and CAv or uh, vh and h2
    are all removed from the restart files.  Remap_dyn_split_RK2b_aux_vars() now has
    nothing to do, and it should probably be eliminated altogether in a subsequent
    commit.
    
      All answers are changed when SPLIT_RK2B = True, and there are changes to the
    contents of the restart files.
    Hallberg-NOAA committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a4e717c View commit details
    Browse the repository at this point in the history
  3. Regroup MOM_dynamics_split_RK2b halo updates

      This commit includes further revisions to MOM_dynamics_split_RK2b that avoid
    some unnecessary calculations and group some of the halo updates into fewer
    group passes.  All answers are bitwise identical.
    Hallberg-NOAA committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    9272d68 View commit details
    Browse the repository at this point in the history
  4. +Correct description of SPLIT_RK2B

      Corrected the description of the runtime parameter SPLIT_RK2B that will appear
    in the MOM_parameter_doc files and in the doxygen descriptions of the MOM module
    to better reflect what was ultimately being done with this new scheme.  All
    answers are bitwise identical, but there are changes to the (newly added)
    contents of some MOM_parameter_doc files.
    Hallberg-NOAA committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    22c3499 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Configuration menu
    Copy the full SHA
    e46c5c8 View commit details
    Browse the repository at this point in the history