Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+tracer_Z_init can rescale tracers #555

Merged

Conversation

Hallberg-NOAA
Copy link
Member

Added the new optional scale argument to tracer_Z_init() to allow the units of the tracers that it initializes from a z-space file to be rescaled, similarly to what is already done in tracer_z_init_array(). This also required the addition of the new missing_scale argument to the private routine read_Z_edges() to specify how the missing values are rescaled. Comments were also added or modified describing 28 real variables or their units in this module. By default all answers are bitwise identical, but when this new option is exercised, answers could change at roundoff for some non-Boussinesq cases.

  Added the new optional scale argument to tracer_Z_init to allow the units of
the tracers that it initializes from a z-space file to be rescaled, similarly to
what is already done in tracer_z_init_array.  This also required the addition of
the new missing_scale argument to the private routine read_Z_edges to specify
how the missing values are rescaled. Comments were also added or modified
describing 28 real variables or their units in this module.  By default all
answers are bitwise identical, but when this new option is exercised, answers
could change at roundoff for some non-Boussinesq cases.
@Hallberg-NOAA Hallberg-NOAA added the enhancement New feature or request label Jan 28, 2024
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f14a681) 37.20% compared to head (8640a6d) 37.20%.

Files Patch % Lines
src/tracer/MOM_tracer_Z_init.F90 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/gfdl     #555      +/-   ##
============================================
- Coverage     37.20%   37.20%   -0.01%     
============================================
  Files           271      271              
  Lines         80456    80457       +1     
  Branches      15001    15002       +1     
============================================
  Hits          29932    29932              
- Misses        44957    44958       +1     
  Partials       5567     5567              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22390 ✔️

@marshallward marshallward merged commit 3f7465a into NOAA-GFDL:dev/gfdl Feb 21, 2024
12 checks passed
@Hallberg-NOAA Hallberg-NOAA deleted the rescale_with_tracer_Z_init branch May 10, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants