Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Rotationally symmetric neutral diffusion option #576

Conversation

Hallberg-NOAA
Copy link
Member

Added the option to do neutral tracer diffusion with expressions that satisfy rotational symmetry. This option is enabled by setting the new runtime parameter NDIFF_ANSWER_DATE to be greater than 20240229. By default, this parameter is set to use the previous expressions, although the default may be changed later to follow DEFAULT_ANSWER_DATE. By default all answers are bitwise identical, but there are changes to some MOM_parameter_doc files due to the introduction of a new runtime parameter.

@Hallberg-NOAA Hallberg-NOAA added the enhancement New feature or request label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.13%. Comparing base (4fd0162) to head (07ad555).

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/gfdl     #576      +/-   ##
============================================
- Coverage     37.14%   37.13%   -0.01%     
============================================
  Files           271      271              
  Lines         80736    80767      +31     
  Branches      15064    15066       +2     
============================================
+ Hits          29988    29994       +6     
- Misses        45150    45174      +24     
- Partials       5598     5599       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

  Added the option to do neutral tracer diffusion with expressions that satisfy
rotational symmetry.  This option is enabled by setting the new runtime
parameter NDIFF_ANSWER_DATE to be greater than 20240330.  By default, this
parameter is set to use the previous expressions, although the default may be
changed later to follow DEFAULT_ANSWER_DATE.  By default all answers are bitwise
identical, but there are changes to some MOM_parameter_doc files due to the
introduction of a new runtime parameter.
@Hallberg-NOAA Hallberg-NOAA force-pushed the neutral_diffusion_rotational_sym branch from 6530d29 to 07ad555 Compare March 18, 2024 21:41
@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22737 ✔️ 🟡

@marshallward marshallward merged commit 32f6316 into NOAA-GFDL:dev/gfdl Mar 21, 2024
12 checks passed
@Hallberg-NOAA Hallberg-NOAA deleted the neutral_diffusion_rotational_sym branch May 10, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants