Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation bugfixes #584

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Commits on Mar 15, 2024

  1. Rotation bugfixes

    This patch contains several bugfixes associated with the rotational grid
    testing.
    
    The following checksums are declared as scalar pairs, rather than
    vectors:
    
    * eta_[uv] (in porous barrier)
    * por_face_area[UV]
    * por_layer_width[UV]
    * Ray_[uv] (Rayleigh drag velocity)
    
    Fluxes and surface fields are now permitted to contain tracer fluxes
    (tr_fluxes) when rotation is enabled.  The fields are retained in their
    unrotated form, since these are accessed and handled outside of MOM6.
    
    The rotated p_surf_SSH pointer in forces now correctly points to either
    p_surf or p_surf_full.
    
    read_netcdf_nc() now correctly uses the unrotated horizontal index
    struct HI, used to access the contents of the file.  Previously, it was
    using the model HI, which may be rotated.
    
    Reading chlorophyll with time_interp_external now uses rotation to
    correctly fetch its output.
    
    NOTE: This could be cleaned up so that the rotation details are hidden
    from users, but there are some unresolved issues around how to approach
    this.
    marshallward authored and Hallberg-NOAA committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    611f8cd View commit details
    Browse the repository at this point in the history