(*)Avoiding using RHO_0 in non-Boussinesq debugging #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in non-Boussinesq mode, write out mass-based tracer inventories from calls to MOM_tracer_chkinv and mean thicknesses in mass per unit area from calls to MOM_state_stats, rather than the approximate volumes that depend on the Boussinesq reference density. Similarly the thicknesses and transports output by write_u_accel and write_v_accel are in mass per unit area or mass flux per unit face length in non-Boussinesq mode. This is done specifically by using GV%H_to_MKS in place of GV%H_to_m; these are identical in Boussinesq mode, but GV%H_to_MKS avoids rescaling by the Boussinesq reference density in non-Boussinesq mode. Several comments were also updated to reflect these changes. All solutions are identical, but there are changes in the units of several diagnostic output fields that the model can write out when debugging non-Boussinesq mode runs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #588 +/- ##
============================================
- Coverage 37.07% 36.93% -0.15%
============================================
Files 271 271
Lines 80966 79328 -1638
Branches 15118 14748 -370
============================================
- Hits 30019 29297 -722
+ Misses 45324 44579 -745
+ Partials 5623 5452 -171 ☔ View full report in Codecov by Sentry. |
marshallward
approved these changes
Apr 10, 2024
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/23067 ✔️ |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in non-Boussinesq mode, write out mass-based tracer inventories from calls to
MOM_tracer_chkinv()and mean thicknesses in mass per unit area from calls toMOM_state_stats(), rather than the approximate volumes that depend on the Boussinesq reference density. Similarly the thicknesses and transports output bywrite_u_accel()andwrite_v_accel()are in mass per unit area or mass flux per unit face length in non-Boussinesq mode. This is done specifically by usingGV%H_to_MKSin place ofGV%H_to_m; these are identical in Boussinesq mode, butGV%H_to_MKSavoids rescaling by the Boussinesq reference density in non-Boussinesq mode. Several comments were also updated to reflect these changes. All solutions are identical, but there are changes in the units of several diagnostic output fields that the model can write out when debugging non-Boussinesq mode runs.